linux-kernel - Re: [PATCH] slab: Fix too strict alignment check in create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <170f59ce-7739-2e84-35d9-fc6da6955ae1@gentwo.org>
Date: Fri, 22 Nov 2024 10:54:39 -0800 (PST)
From: "Christoph Lameter (Ampere)" <cl@...two.org>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
cc: Guenter Roeck <linux@...ck-us.net>, 
    Geert Uytterhoeven <geert@...ux-m68k.org>, 
    Vlastimil Babka <vbabka@...e.cz>, Pekka Enberg <penberg@...nel.org>, 
    David Rientjes <rientjes@...gle.com>, Joonsoo Kim <iamjoonsoo.kim@....com>, 
    Andrew Morton <akpm@...ux-foundation.org>, 
    Roman Gushchin <roman.gushchin@...ux.dev>, 
    Hyeonggon Yoo <42.hyeyoo@...il.com>, Jens Axboe <axboe@...nel.dk>, 
    Pavel Begunkov <asml.silence@...il.com>, Mike Rapoport <rppt@...nel.org>, 
    Christian Brauner <brauner@...nel.org>, Kees Cook <keescook@...omium.org>, 
    Jann Horn <jannh@...gle.com>, linux-mm@...ck.org, io-uring@...r.kernel.org, 
    linux-m68k@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] slab: Fix too strict alignment check in create_cache()

On Fri, 22 Nov 2024, Lorenzo Stoakes wrote:

> An aside, but note that there is a proposal to add nommu support to UML,
> which would entirely prevent our ability to eliminate it [0] (though it
> would make testing it easier! :)

Ok back to the alignment check. The patch is ok and an improvement since
it properly checks for the alignment of the scalar and does not assume
that a scalar is naturally aligned. That may not be necessary but it is
formally more correct.

So

Acked-by: Christoph Lameter <cl@...ux.com>