linux-kernel - Re: [PATCH] arm64: Fix usage of new shifted MDCR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86mshrulw8.wl-maz@kernel.org>
Date: Fri, 22 Nov 2024 19:08:23 +0000
From: Marc Zyngier <maz@...nel.org>
To: James Clark <james.clark@...aro.org>
Cc: will@...nel.org,
	kvmarm@...ts.linux.dev,
	oliver.upton@...ux.dev,
	linux-arm-kernel@...ts.infradead.org,
	Catalin Marinas <catalin.marinas@....com>,
	Joey Gouly <joey.gouly@....com>,
	Suzuki K Poulose <suzuki.poulose@....com>,
	Zenghui Yu <yuzenghui@...wei.com>,
	Yicong Yang <yangyicong@...ilicon.com>,
	Dave Martin <Dave.Martin@....com>,
	Fuad Tabba <tabba@...gle.com>,
	James Morse <james.morse@....com>,
	Mark Rutland <mark.rutland@....com>,
	Anshuman Khandual <anshuman.khandual@....com>,
	Vincent Donnefort <vdonnefort@...gle.com>,
	Quentin Perret <qperret@...gle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: Fix usage of new shifted MDCR_EL2 values

On Fri, 22 Nov 2024 16:46:35 +0000,
James Clark <james.clark@...aro.org> wrote:
> 
> Since the linked fixes commit, these masks are already shifted so remove
> the shifts. One issue that this fixes is SPE and TRBE not being
> available anymore:
> 
>  arm_spe_pmu arm,spe-v1: profiling buffer owned by higher exception level
> 
> Fixes: 641630313e9c ("arm64: sysreg: Migrate MDCR_EL2 definition to table")
> Signed-off-by: James Clark <james.clark@...aro.org>

Huh, well spotted. This is doubleplusungood. Thankfully, the KVM/arm64
tree hasn't reached Linus yet, but this needs quick fixing.

Acked-by: Marc Zyngier <maz@...nel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.