linux-kernel - Re: RTL9300 (mips) fails to boot with commit d4a7f2510ff4 ("vmlinux.lds.h: Adjust symbol ordering in text output section")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84d9200e-25b4-4bd8-8eb5-c954ff92ac08@alliedtelesis.co.nz>
Date: Fri, 22 Nov 2024 15:29:09 +1300
From: Chris Packham <chris.packham@...iedtelesis.co.nz>
To: Rong Xu <xur@...gle.com>,
 "Han Yao Yeo (atg)" <hanyao.yeo@...iedtelesis.com.sg>,
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 Masahiro Gotoh <gotoh@...ied-telesis.co.jp>
Cc: "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: RTL9300 (mips) fails to boot with commit d4a7f2510ff4
 ("vmlinux.lds.h: Adjust symbol ordering in text output section")


On 22/11/24 14:58, Chris Packham wrote:
> Hi Rong,
>
> I was just trying some of my in-flight changes against linux-next and 
> found that my RTL9300* based board no longer boots (nothing on the 
> serial console after U-Boot hands off to the kernel).
>
> A bisect between Linus's tree and linux-next/master points to commit 
> d4a7f2510ff4 ("vmlinux.lds.h: Adjust symbol ordering in text output 
> section"). A build on d4a7f2510ff4^ boots successfully. That series is 
> well beyond my area of knowledge, there may be something that the MIPS 
> SoCs are doing (or not doing) that is being affected by the sections 
> moving.

Based on the sparc change that accompanied this commit the following 
does seem to restore working order for me:

diff --git a/arch/mips/kernel/vmlinux.lds.S b/arch/mips/kernel/vmlinux.lds.S
index d575f945d422..e90b0f68290c 100644
--- a/arch/mips/kernel/vmlinux.lds.S
+++ b/arch/mips/kernel/vmlinux.lds.S
@@ -62,6 +62,8 @@ SECTIONS
         _text = .;      /* Text and read-only data */
         _stext = .;
         .text : {
+               /* Match text section symbols in head.S first */
+               *head.o(.text)
                 TEXT_TEXT
                 SCHED_TEXT
                 LOCK_TEXT

No idea if that's appropriate