linux-kernel - Re: [PATCH] delay: Fix ndelay() spuriously treated as udelay()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXv+5HtG+6D8245DFAeSKfGL75zVkEGLu74=hqtjX=-Dpj70Q@mail.gmail.com>
Date: Fri, 22 Nov 2024 10:36:14 +0800
From: Chen-Yu Tsai <wenst@...omium.org>
To: Frederic Weisbecker <frederic@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, LKML <linux-kernel@...r.kernel.org>, 
	Nícolas F. R. A. Prado <nfraprado@...labora.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
	Anna-Maria Behnsen <anna-maria@...utronix.de>
Subject: Re: [PATCH] delay: Fix ndelay() spuriously treated as udelay()

On Thu, Nov 21, 2024 at 11:30 PM Frederic Weisbecker
<frederic@...nel.org> wrote:
>
> A recent rework on delay functions wrongly ended up calling __udelay()
> instead of __ndelay() for nanosecond delays, increasing those by 1000.
>
> As a result hangs have been observed on boot
>
> Restore the right function calls.
>
> Fixes: 19e2d91d8cb1 ("delay: Rework udelay and ndelay")
> Reported-by: Chen-Yu Tsai <wenst@...omium.org>
> Signed-off-by: Frederic Weisbecker <frederic@...nel.org>

Tested-by: Chen-Yu Tsai <wenst@...omium.org>
Reviewed-by: Chen-Yu Tsai <wenst@...omium.org>

Thank you for the quick response! This fixed things for me.

> ---
>  include/asm-generic/delay.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/asm-generic/delay.h b/include/asm-generic/delay.h
> index 76cf237b6e4c..03b0ec7afca6 100644
> --- a/include/asm-generic/delay.h
> +++ b/include/asm-generic/delay.h
> @@ -75,11 +75,11 @@ static __always_inline void ndelay(unsigned long nsec)
>  {
>         if (__builtin_constant_p(nsec)) {
>                 if (nsec >= DELAY_CONST_MAX)
> -                       __bad_udelay();
> +                       __bad_ndelay();
>                 else
>                         __const_udelay(nsec * NDELAY_CONST_MULT);
>         } else {
> -               __udelay(nsec);
> +               __ndelay(nsec);
>         }
>  }
>  #define ndelay(x) ndelay(x)
> --
> 2.46.0
>