linux-kernel - Re: [PATCH v3] PCI: hotplug: Add a generic RAS tracepoint for hotplug event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e96ed0ee-01c8-4429-a903-17bc7813d78a@linux.alibaba.com>
Date: Fri, 22 Nov 2024 14:25:33 +0800
From: Shuai Xue <xueshuai@...ux.alibaba.com>
To: Steven Rostedt <rostedt@...dmis.org>, Lukas Wunner <lukas@...ner.de>
Cc: linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-edac@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 bhelgaas@...gle.com, tony.luck@...el.com, bp@...en8.de, mhiramat@...nel.org,
 mathieu.desnoyers@...icios.com, oleg@...hat.com, naveen@...nel.org,
 davem@...emloft.net, anil.s.keshavamurthy@...el.com, mark.rutland@....com,
 peterz@...radead.org
Subject: Re: [PATCH v3] PCI: hotplug: Add a generic RAS tracepoint for hotplug
 event



在 2024/11/22 08:08, Steven Rostedt 写道:
> On Fri, 22 Nov 2024 00:09:50 +0100
> Lukas Wunner <lukas@...ner.de> wrote:
> 
>> Would something like
>>
>>    /sys/kernel/debug/tracing/events/pci/hotplug_event
>>
>> be possible?  It would seem more elegant than
>>
>>    /sys/kernel/debug/tracing/events/pci/pci_hp_event
>>
>> because it avoids the duplication of "pci" in the path.
> 
> Most events have the name of the system in it (see the sched events).
> That's to prevent the duplicates in other places. Also, in the trace
> output, only the event name is shown and not the system. That is, if you
> have more than one "hotplug_event" enabled, the trace will not
> differentiate them.
> 
> My suggestion is the "pci_hp_event" as it will be more obvious in the trace
> output.
> 
> -- Steve

Agreed. pci_hp_event is more reasonable. Than is:

- system: pci
- event: pci_hp_event

/sys/kernel/debug/tracing/events/pci/pci_hp_event

@Lukas, if you have any other concerns, please let me know.


Thank you.
Best Regards,
Shuai