linux-kernel - Re: [PATCH md-6.13 5/5] md/md-bitmap: move bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e3319ea0-f9aa-6048-c620-4e72f2b10b31@huaweicloud.com>
Date: Fri, 22 Nov 2024 16:32:25 +0800
From: Yu Kuai <yukuai1@...weicloud.com>
To: Xiao Ni <xni@...hat.com>, Yu Kuai <yukuai1@...weicloud.com>
Cc: song@...nel.org, linux-raid@...r.kernel.org,
 linux-kernel@...r.kernel.org, yi.zhang@...wei.com, yangerkun@...wei.com,
 "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH md-6.13 5/5] md/md-bitmap: move bitmap_{start, end}write
 to md upper layer

Hi,

在 2024/11/22 11:14, Xiao Ni 写道:
>> Ok, one place that I found is that raid5 can do extra end write while
>> stripe->dev[].towrite is NULL, the null checking is missing. I'll
>> mention that in the next version.
> Does this can cause the deadlock?

Not deadlock, the bit counter will underflow and reach COUNTER_MAX, and
bitmap_startwrite() can wait forever for the counter.

Thanks,
Kuai