linux-kernel - Re: [PATCH 3/3] i2c: atr: Fix client detach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z0BOJpCV22nzZgHS@smile.fi.intel.com>
Date: Fri, 22 Nov 2024 11:25:58 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
Cc: Luca Ceresoli <luca.ceresoli@...tlin.com>,
	Wolfram Sang <wsa+renesas@...g-engineering.com>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	Wolfram Sang <wsa@...nel.org>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Cosmin Tanislav <demonsingur@...il.com>,
	Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>,
	stable@...r.kernel.org
Subject: Re: [PATCH 3/3] i2c: atr: Fix client detach

On Fri, Nov 22, 2024 at 09:51:40AM +0200, Tomi Valkeinen wrote:
> From: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>
> 
> i2c-atr catches the BUS_NOTIFY_DEL_DEVICE event on the bus and removes
> the translation by calling i2c_atr_detach_client().
> 
> However, BUS_NOTIFY_DEL_DEVICE happens when the device is about to be
> removed from this bus, i.e. before removal, and thus before calling
> .remove() on the driver. If the driver happens to do any i2c
> transactions in its remove(), they will fail.
> 
> Fix this by catching BUS_NOTIFY_REMOVED_DEVICE instead, thus removing
> the translation only after the device is actually removed.

...

> Fixes: a076a860acae ("media: i2c: add I2C Address Translator (ATR) support")

Fixes should lead the patch series, and other way around.

-- 
With Best Regards,
Andy Shevchenko