linux-kernel - Re: [PATCH net] netpoll: Use rtnl_dereference() for npinfo pointer access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241122-pronghorn-of-astonishing-innovation-dd8d6b@leitao>
Date: Fri, 22 Nov 2024 01:31:09 -0800
From: Breno Leitao <leitao@...ian.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
	Michal Kubiak <michal.kubiak@...el.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-team@...a.com,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH net] netpoll: Use rtnl_dereference() for npinfo pointer
 access

On Thu, Nov 21, 2024 at 07:56:16PM -0800, Jakub Kicinski wrote:
> On Fri, 22 Nov 2024 00:41:14 +0100 Eric Dumazet wrote:
> > > Fixes: c75964e40e69 ("netpoll: Use rtnl_dereference() for npinfo pointer access")  
> > 
> > This seems wrong. This sha1 does not exist, and the title is this patch.
> > 
> > We do not send a patch saying it is fixing itself.
> > 
> > I would suggest instead :
> > 
> > Fixes: c69c5e10adb9 ("netpoll: Use rcu_access_pointer() in __netpoll_setup")
> 
> Or no Fixes tag and net-next...
> 
> I'm missing what can go wrong here, seems like a cleanup.

I decide to sent to net due Herbert's concern about the previous patch.

I will send a v2 targeting net-next, then.

Thanks for the review,
--breno