linux-kernel - [PATCH 2/2] rtc: ab-eoz9: don't fail temperature reads on undervoltage notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241122101031.68916-3-maxime.chevallier@bootlin.com>
Date: Fri, 22 Nov 2024 11:10:30 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Artem Panfilov <panfilov.artyom@...il.com>
Cc: Maxime Chevallier <maxime.chevallier@...tlin.com>,
	linux-rtc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Alexis Lothoré <alexis.lothore@...tlin.com>,
	thomas.petazzoni@...tlin.com
Subject: [PATCH 2/2] rtc: ab-eoz9: don't fail temperature reads on undervoltage notification

The undervoltage flags reported by the RTC are useful to know if the
time and date are reliable after a reboot. Although the threshold VLOW1
indicates that the thermometer has been shutdown and time compensation
is off, it doesn't mean that the temperature readout is currently
impossible.

As the system is running, the RTC voltage is now fully established and
we can read the temperature.

Fixes: 67075b63cce2 ("rtc: add AB-RTCMC-32.768kHz-EOZ9 RTC support")
Signed-off-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
---
 drivers/rtc/rtc-ab-eoz9.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/rtc/rtc-ab-eoz9.c b/drivers/rtc/rtc-ab-eoz9.c
index 85853da258d2..52914bb3e5e1 100644
--- a/drivers/rtc/rtc-ab-eoz9.c
+++ b/drivers/rtc/rtc-ab-eoz9.c
@@ -396,13 +396,6 @@ static int abeoz9z3_temp_read(struct device *dev,
 	if (ret < 0)
 		return ret;
 
-	if ((val & ABEOZ9_REG_CTRL_STATUS_V1F) ||
-	    (val & ABEOZ9_REG_CTRL_STATUS_V2F)) {
-		dev_err(dev,
-			"thermometer might be disabled due to low voltage\n");
-		return -EINVAL;
-	}
-
 	switch (attr) {
 	case hwmon_temp_input:
 		ret = regmap_read(regmap, ABEOZ9_REG_REG_TEMP, &val);
-- 
2.47.0