linux-kernel - Re: [RFC PATCH v3 06/15] jump_label: Add forceful jump label type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <xhsmha5dra7ya.mognet@vschneid-thinkpadt14sgen2i.remote.csb>
Date: Fri, 22 Nov 2024 11:17:33 +0100
From: Valentin Schneider <vschneid@...hat.com>
To: Josh Poimboeuf <jpoimboe@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, kvm@...r.kernel.org, linux-mm@...ck.org,
 bpf@...r.kernel.org, x86@...nel.org, rcu@...r.kernel.org,
 linux-kselftest@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
 Masami Hiramatsu <mhiramat@...nel.org>, Jonathan Corbet <corbet@....net>,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
 "H. Peter Anvin" <hpa@...or.com>, Paolo Bonzini <pbonzini@...hat.com>,
 Wanpeng Li <wanpengli@...cent.com>, Vitaly Kuznetsov
 <vkuznets@...hat.com>, Andy Lutomirski <luto@...nel.org>, Frederic
 Weisbecker <frederic@...nel.org>, "Paul E. McKenney" <paulmck@...nel.org>,
 Neeraj Upadhyay <quic_neeraju@...cinc.com>, Joel Fernandes
 <joel@...lfernandes.org>, Josh Triplett <josh@...htriplett.org>, Boqun
 Feng <boqun.feng@...il.com>, Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>, Lai Jiangshan <jiangshanlai@...il.com>,
 Zqiang <qiang.zhang1211@...il.com>, Andrew Morton
 <akpm@...ux-foundation.org>, Uladzislau Rezki <urezki@...il.com>,
 Christoph Hellwig <hch@...radead.org>, Lorenzo Stoakes
 <lstoakes@...il.com>, Jason Baron <jbaron@...mai.com>, Kees Cook
 <keescook@...omium.org>, Sami Tolvanen <samitolvanen@...gle.com>, Ard
 Biesheuvel <ardb@...nel.org>, Nicholas Piggin <npiggin@...il.com>, Juerg
 Haefliger <juerg.haefliger@...onical.com>, Nicolas Saenz Julienne
 <nsaenz@...nel.org>, "Kirill A. Shutemov"
 <kirill.shutemov@...ux.intel.com>, Dan Carpenter <error27@...il.com>,
 Chuang Wang <nashuiliang@...il.com>, Yang Jihong <yangjihong1@...wei.com>,
 Petr Mladek <pmladek@...e.com>, "Jason A. Donenfeld" <Jason@...c4.com>,
 Song Liu <song@...nel.org>, Julian Pidancet <julian.pidancet@...cle.com>,
 Tom Lendacky <thomas.lendacky@....com>, Dionna Glaze
 <dionnaglaze@...gle.com>, Thomas Weißschuh
 <linux@...ssschuh.net>, Juri
 Lelli <juri.lelli@...hat.com>, Marcelo Tosatti <mtosatti@...hat.com>, Yair
 Podemsky <ypodemsk@...hat.com>, Daniel Wagner <dwagner@...e.de>, Petr
 Tesarik <ptesarik@...e.com>
Subject: Re: [RFC PATCH v3 06/15] jump_label: Add forceful jump label type

On 21/11/24 12:21, Josh Poimboeuf wrote:
> On Thu, Nov 21, 2024 at 04:51:09PM +0100, Valentin Schneider wrote:
>> Okay so forcing the IPI for .noinstr patching lets us get rid of all the
>> force_ipi faff; however I would still want the special marking to tell
>> objtool "yep we're okay with this one", and still get warnings when a new
>> .noinstr key gets added so we double think about it.
>
> Yeah.  Though, instead of DECLARE_STATIC_KEY_FALSE_NOINSTR adding a new
> jump label type, it could just add an objtool annotation pointing to the
> key.  If that's the way we're going I could whip up a patch if that
> would help.
>

Well I'm down for the approach and I'd appreciate help for the objtool side
:-)

> --
> Josh