linux-kernel - Re: [PATCH] ASoC: Intel: avs: Add error handling in avs_tplg_parse_initial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <970b517b-f1c7-4c18-88a8-aba5c2b6200c@intel.com>
Date: Fri, 22 Nov 2024 12:10:52 +0100
From: Cezary Rojewski <cezary.rojewski@...el.com>
To: Zhu Jun <zhujun2@...s.chinamobile.com>
CC: <tiwai@...e.com>, <linux-sound@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Jaroslav Kysela <perex@...ex.cz>, Mark Brown
	<broonie@...nel.org>
Subject: Re: [PATCH] ASoC: Intel: avs: Add error handling in
 avs_tplg_parse_initial_configs


On 2024-11-22 7:32 AM, Zhu Jun wrote:
> Introduce error handling in avs_tplg_parse_initial_configs to ensure that
> the function returns immediately if parse_dictionary_entries fails.

Nitpick: mention functions with '()' to make them stand out next to 
their struct/field friends, e.g.: avs_tplg_parse_initial_configs().

> 
> Signed-off-by: Zhu Jun <zhujun2@...s.chinamobile.com>
> ---
>   sound/soc/intel/avs/topology.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/avs/topology.c b/sound/soc/intel/avs/topology.c
> index 5cda52702..3f76581af 100644
> --- a/sound/soc/intel/avs/topology.c
> +++ b/sound/soc/intel/avs/topology.c
> @@ -1500,7 +1500,6 @@ static int avs_tplg_parse_initial_configs(struct snd_soc_component *comp,
>   				      AVS_TKN_MANIFEST_NUM_INIT_CONFIGS_U32);
>   	if (ret)
>   		return ret;
> -

Spurious whitespace change. Please remove.

>   	block_size -= le32_to_cpu(tuples->size);
>   	/* With header parsed, move on to parsing entries. */
>   	tuples = avs_tplg_vendor_array_next(tuples);
> @@ -1522,6 +1521,8 @@ static int avs_tplg_parse_initial_configs(struct snd_soc_component *comp,
>   					       AVS_TKN_MOD_INIT_CONFIG_ID_U32,
>   					       mod_init_config_parsers,
>   					       ARRAY_SIZE(mod_init_config_parsers));
> +		if (ret)
> +			return ret;
>   

Agree, outcome of parse_dictionary_entries() shall be verified.

>   		block_size -= esize;
>   

Jun, in future, please remember to add Mark Brown to the list, he's the 
maintainer who governs the ASoC subsystem. If you are unsure who 
maintains what, ./scripts/get_maintainer.pl should help with that.