linux-kernel - Re: [PATCH] ALSA: hda: cs35l41: Support HP Elite Dragonfly 13.5 inch G4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de0f8e31-f1ca-4a96-99a9-45439c7463a7@opensource.cirrus.com>
Date: Fri, 22 Nov 2024 10:59:33 +0000
From: Stefan Binding <sbinding@...nsource.cirrus.com>
To: Nicholas Wang <me@...ho1as.wang>
CC: David Rhodes <david.rhodes@...rus.com>,
        Richard Fitzgerald
	<rf@...nsource.cirrus.com>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai
	<tiwai@...e.com>,
        <linux-sound@...r.kernel.org>, <patches@...nsource.cirrus.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: hda: cs35l41: Support HP Elite Dragonfly 13.5 inch
 G4

Hi,

This laptop should have valid _DSD, which would mean that it shouldn’t need to be added into the configuration table.
I can see the cs_gpio_index field set to -1 in this patch, which should only be valid for this laptop if there is valid cs-gpios _DSD in the ACPI.
Did the laptop have some kind of issue which prompted this patch?
Is there a BugZilla for this issue?
Can you send me a dmesg log of this issue so I can investigate?
Can you also send an acpidump of your laptop?

Thanks,

Stefan

On 22/11/2024 04:44, Nicholas Wang wrote:
> This laptop needs to be supported via the configuration table.
>
> Signed-off-by: Nicholas Wang <me@...ho1as.wang>
> ---
>  sound/pci/hda/cs35l41_hda_property.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/sound/pci/hda/cs35l41_hda_property.c b/sound/pci/hda/cs35l41_hda_property.c
> index 61d231483..c97b8f808 100644
> --- a/sound/pci/hda/cs35l41_hda_property.c
> +++ b/sound/pci/hda/cs35l41_hda_property.c
> @@ -52,6 +52,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
>  	{ "103C8A30", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
>  	{ "103C8A31", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
>  	{ "103C8A6E", 4, EXTERNAL, { CS35L41_LEFT, CS35L41_LEFT, CS35L41_RIGHT, CS35L41_RIGHT }, 0, -1, -1, 0, 0, 0 },
> +	{ "103C8B63", 4, EXTERNAL, { CS35L41_RIGHT, CS35L41_LEFT, CS35L41_RIGHT, CS35L41_LEFT }, 0, -1, -1, 0, 0, 0 },
>  	{ "103C8BB3", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
>  	{ "103C8BB4", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
>  	{ "103C8BDD", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
> @@ -467,6 +468,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
>  	{ "CSC3551", "103C8A30", generic_dsd_config },
>  	{ "CSC3551", "103C8A31", generic_dsd_config },
>  	{ "CSC3551", "103C8A6E", generic_dsd_config },
> +	{ "CSC3551", "103C8B63", generic_dsd_config },
>  	{ "CSC3551", "103C8BB3", generic_dsd_config },
>  	{ "CSC3551", "103C8BB4", generic_dsd_config },
>  	{ "CSC3551", "103C8BDD", generic_dsd_config },