linux-kernel - Re: [PATCH v3 04/13] rust: hrtimer: implement `TimerPointer` for `Arc`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72mkBufEV43HcZZVKB=1UDxOrpweFxeZJBXt6U0=vPMsdg@mail.gmail.com>
Date: Fri, 22 Nov 2024 13:36:25 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Andreas Hindborg <a.hindborg@...nel.org>
Cc: Lyude Paul <lyude@...hat.com>, Miguel Ojeda <ojeda@...nel.org>, 
	Anna-Maria Behnsen <anna-maria@...utronix.de>, Frederic Weisbecker <frederic@...nel.org>, 
	Thomas Gleixner <tglx@...utronix.de>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Alice Ryhl <aliceryhl@...gle.com>, 
	Trevor Gross <tmgross@...ch.edu>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 04/13] rust: hrtimer: implement `TimerPointer` for `Arc`

On Wed, Nov 20, 2024 at 4:52 PM Andreas Hindborg <a.hindborg@...nel.org> wrote:
>
> No particular reason. It is often easier to rebase things around when
> they are on their own line.
>
> Are there any code guidelines to follow on this?

Not yet -- we have a mixture of styles, though we typically don't go
to the item-level like in this patch, and instead have done it closer
to the "Crate" or "Module" styles.

Ideally we would automate at least to some degree, but currently the
relevant `rustfmt` options are unstable:

    https://rust-lang.github.io/rustfmt/#imports_indent
    https://rust-lang.github.io/rustfmt/#imports_layout
    https://rust-lang.github.io/rustfmt/#imports_granularity
    https://rust-lang.github.io/rustfmt/#group_imports

I agree that deciding on one style would be nice (especially if it is
reasonable to expect that the style would be eventually supported by
`rustfmt`).

Cheers,
Miguel