linux-kernel - Re: [PATCH] spi: atmel-quadspi: Fix register name in verbose logging function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241122-zips-module-d0e6c6a1e69b@thorsis.com>
Date: Fri, 22 Nov 2024 15:25:47 +0100
From: Alexander Dahl <ada@...rsis.com>
To: Csókás, Bence <csokas.bence@...lan.hu>
Cc: Tudor Ambarus <tudor.ambarus@...aro.org>,
	Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Claudiu Beznea <claudiu.beznea@...on.dev>
Subject: Re: [PATCH] spi: atmel-quadspi: Fix register name in verbose logging
 function

Hello,

Am Fri, Nov 22, 2024 at 03:13:02PM +0100 schrieb Csókás, Bence:
> `atmel_qspi_reg_name()` is used for pretty-printing register offsets
> for verbose logging of register accesses. However, due to a typo
> (likely a copy-paste error), QSPI_RD's offset prnts as "MR", the
> name of the previous register. Fix this typo.
> 
> Fixes: c528ecfbef04 ("spi: atmel-quadspi: Add verbose debug facilities to monitor register accesses")
> Signed-off-by: Csókás, Bence <csokas.bence@...lan.hu>
> ---
>  drivers/spi/atmel-quadspi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
> index 91108ddfaef2..316bce577081 100644
> --- a/drivers/spi/atmel-quadspi.c
> +++ b/drivers/spi/atmel-quadspi.c
> @@ -183,7 +183,7 @@ static const char *atmel_qspi_reg_name(u32 offset, char *tmp, size_t sz)
>  	case QSPI_MR:
>  		return "MR";
>  	case QSPI_RD:
> -		return "MR";
> +		return "RD";
>  	case QSPI_TD:
>  		return "TD";
>  	case QSPI_SR:

Reviewed-by: Alexander Dahl <ada@...rsis.com>

Greets
Alex