linux-kernel - Re: [PATCH v4 8/9] binder: propagate vm_insert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJuCfpGb_kT98GTmahG9ZOYadBMY0xPe-DSfEFWx9Rskq2vRrQ@mail.gmail.com>
Date: Fri, 22 Nov 2024 07:49:46 -0800
From: Suren Baghdasaryan <surenb@...gle.com>
To: Carlos Llamas <cmllamas@...gle.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Arve Hjønnevåg <arve@...roid.com>, 
	Todd Kjos <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>, 
	Joel Fernandes <joel@...lfernandes.org>, Christian Brauner <brauner@...nel.org>, 
	linux-kernel@...r.kernel.org, kernel-team@...roid.com
Subject: Re: [PATCH v4 8/9] binder: propagate vm_insert_page() errors

On Tue, Nov 19, 2024 at 10:33 AM Carlos Llamas <cmllamas@...gle.com> wrote:
>
> Instead of always overriding errors with -ENOMEM, propagate the specific
> error code returned by vm_insert_page(). This allows for more accurate
> error logs and handling.
>
> Cc: Suren Baghdasaryan <surenb@...gle.com>
> Signed-off-by: Carlos Llamas <cmllamas@...gle.com>

Reviewed-by: Suren Baghdasaryan <surenb@...gle.com>

> ---
>  drivers/android/binder_alloc.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c
> index f5dbaf1d7d65..aea35d475ee8 100644
> --- a/drivers/android/binder_alloc.c
> +++ b/drivers/android/binder_alloc.c
> @@ -339,7 +339,6 @@ static int binder_install_single_page(struct binder_alloc *alloc,
>                 __free_page(page);
>                 pr_err("%d: %s failed to insert page at offset %lx with %d\n",
>                        alloc->pid, __func__, addr - alloc->vm_start, ret);
> -               ret = -ENOMEM;
>                 break;
>         }
>  out:
> --
> 2.47.0.338.g60cca15819-goog
>