| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20241122-google-remove-crtc-index-from-parameter-v2-12-81540742535a@bootlin.com>
Date: Fri, 22 Nov 2024 18:20:16 +0100
From: Louis Chauvet <louis.chauvet@...tlin.com>
To: Maíra Canal <mairacanal@...eup.net>,
Haneen Mohammed <hamohammed.sa@...il.com>, Simona Vetter <simona@...ll.ch>,
Melissa Wen <melissa.srw@...il.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>
Cc: arthurgrillo@...eup.net, jeremie.dautheribes@...tlin.com,
miquel.raynal@...tlin.com, thomas.petazzoni@...tlin.com,
seanpaul@...gle.com, nicolejadeyee@...gle.com, linux-kernel@...r.kernel.org,
dri-devel@...ts.freedesktop.org, Louis Chauvet <louis.chauvet@...tlin.com>
Subject: [PATCH RFC v2 12/18] drm/vkms: Add test for config structure
The config structure is a bit complex in term of memory management. Add
basic test to avoid breaking it in the future.
Signed-off-by: Louis Chauvet <louis.chauvet@...tlin.com>
---
drivers/gpu/drm/vkms/tests/Makefile | 1 +
drivers/gpu/drm/vkms/tests/vkms_config_test.c | 137 ++++++++++++++++++++++++++
2 files changed, 138 insertions(+)
diff --git a/drivers/gpu/drm/vkms/tests/Makefile b/drivers/gpu/drm/vkms/tests/Makefile
index 2d1df668569e4f243ed9a06c1e16e595c131c4f6..ec71b5fe7f9d957eeeabd233bb75c4c250789ff4 100644
--- a/drivers/gpu/drm/vkms/tests/Makefile
+++ b/drivers/gpu/drm/vkms/tests/Makefile
@@ -1,3 +1,4 @@
# SPDX-License-Identifier: GPL-2.0-only
obj-$(CONFIG_DRM_VKMS_KUNIT_TESTS) += vkms_format_test.o
+obj-$(CONFIG_DRM_VKMS_KUNIT_TESTS) += vkms_config_test.o
diff --git a/drivers/gpu/drm/vkms/tests/vkms_config_test.c b/drivers/gpu/drm/vkms/tests/vkms_config_test.c
new file mode 100644
index 0000000000000000000000000000000000000000..12b845bc358aaa44434c6b66184cf17d19656596
--- /dev/null
+++ b/drivers/gpu/drm/vkms/tests/vkms_config_test.c
@@ -0,0 +1,137 @@
+// SPDX-License-Identifier: GPL-2.0+
+
+#include <kunit/test.h>
+
+#include "../vkms_config.h"
+
+MODULE_IMPORT_NS(EXPORTED_FOR_KUNIT_TESTING);
+
+static void vkms_config_test_basic_allocation(struct kunit *test)
+{
+ struct vkms_config *config = vkms_config_create();
+
+ KUNIT_EXPECT_TRUE_MSG(test, list_empty(&config->encoders),
+ "Encoder list is not empty after allocation");
+ KUNIT_EXPECT_TRUE_MSG(test, list_empty(&config->crtcs),
+ "CRTC list is not empty after allocation");
+ KUNIT_EXPECT_TRUE_MSG(test, list_empty(&config->planes),
+ "Plane list is not empty after allocation");
+
+ vkms_config_destroy(config);
+}
+
+static void vkms_config_test_simple_config(struct kunit *test)
+{
+ struct vkms_config *config = vkms_config_create();
+
+ struct vkms_config_plane *plane_1 = vkms_config_create_plane(config);
+ struct vkms_config_plane *plane_2 = vkms_config_create_plane(config);
+ struct vkms_config_crtc *crtc = vkms_config_create_crtc(config);
+ struct vkms_config_encoder *encoder = vkms_config_create_encoder(config);
+
+ KUNIT_EXPECT_FALSE(test, vkms_config_is_valid(config));
+ KUNIT_EXPECT_EQ(test, list_count_nodes(&config->planes), 2);
+ KUNIT_EXPECT_EQ(test, list_count_nodes(&config->crtcs), 1);
+ KUNIT_EXPECT_EQ(test, list_count_nodes(&config->encoders), 1);
+
+ plane_1->type = DRM_PLANE_TYPE_PRIMARY;
+ plane_2->type = DRM_PLANE_TYPE_CURSOR;
+
+ KUNIT_EXPECT_EQ(test, vkms_config_plane_attach_crtc(plane_1, crtc), 0);
+ KUNIT_EXPECT_EQ(test, vkms_config_plane_attach_crtc(plane_2, crtc), 0);
+ KUNIT_EXPECT_EQ(test, vkms_config_encoder_attach_crtc(encoder, crtc), 0);
+
+ KUNIT_EXPECT_TRUE(test, vkms_config_is_valid(config));
+
+ vkms_config_delete_plane(plane_1, config);
+ KUNIT_EXPECT_EQ(test, list_count_nodes(&config->planes), 1);
+ KUNIT_EXPECT_EQ(test, list_count_nodes(&config->crtcs), 1);
+ KUNIT_EXPECT_EQ(test, list_count_nodes(&config->encoders), 1);
+
+ KUNIT_EXPECT_FALSE(test, vkms_config_is_valid(config));
+
+ plane_2->type = DRM_PLANE_TYPE_PRIMARY;
+
+ KUNIT_EXPECT_TRUE(test, vkms_config_is_valid(config));
+
+ vkms_config_destroy(config);
+}
+
+static void vkms_config_test_complex_config(struct kunit *test)
+{
+ struct vkms_config *config = vkms_config_create();
+
+ struct vkms_config_plane *plane_1 = vkms_config_create_plane(config);
+ struct vkms_config_plane *plane_2 = vkms_config_create_plane(config);
+ struct vkms_config_plane *plane_3 = vkms_config_create_plane(config);
+ struct vkms_config_plane *plane_4 = vkms_config_create_plane(config);
+ struct vkms_config_plane *plane_5 = vkms_config_create_plane(config);
+ struct vkms_config_plane *plane_6 = vkms_config_create_plane(config);
+ struct vkms_config_plane *plane_7 = vkms_config_create_plane(config);
+ struct vkms_config_plane *plane_8 = vkms_config_create_plane(config);
+ struct vkms_config_crtc *crtc_1 = vkms_config_create_crtc(config);
+ struct vkms_config_crtc *crtc_2 = vkms_config_create_crtc(config);
+ struct vkms_config_encoder *encoder_1 = vkms_config_create_encoder(config);
+ struct vkms_config_encoder *encoder_2 = vkms_config_create_encoder(config);
+ struct vkms_config_encoder *encoder_3 = vkms_config_create_encoder(config);
+ struct vkms_config_encoder *encoder_4 = vkms_config_create_encoder(config);
+
+ KUNIT_EXPECT_FALSE(test, vkms_config_is_valid(config));
+ KUNIT_EXPECT_EQ(test, list_count_nodes(&config->planes), 8);
+ KUNIT_EXPECT_EQ(test, list_count_nodes(&config->crtcs), 2);
+ KUNIT_EXPECT_EQ(test, list_count_nodes(&config->encoders), 4);
+
+ plane_1->type = DRM_PLANE_TYPE_PRIMARY;
+ plane_2->type = DRM_PLANE_TYPE_CURSOR;
+ plane_3->type = DRM_PLANE_TYPE_OVERLAY;
+ plane_4->type = DRM_PLANE_TYPE_OVERLAY;
+ plane_5->type = DRM_PLANE_TYPE_PRIMARY;
+ plane_6->type = DRM_PLANE_TYPE_CURSOR;
+ plane_7->type = DRM_PLANE_TYPE_OVERLAY;
+ plane_8->type = DRM_PLANE_TYPE_OVERLAY;
+
+ KUNIT_EXPECT_EQ(test, vkms_config_plane_attach_crtc(plane_1, crtc_1), 0);
+ KUNIT_EXPECT_EQ(test, vkms_config_plane_attach_crtc(plane_2, crtc_1), 0);
+ KUNIT_EXPECT_EQ(test, vkms_config_plane_attach_crtc(plane_3, crtc_1), 0);
+ KUNIT_EXPECT_EQ(test, vkms_config_plane_attach_crtc(plane_4, crtc_1), 0);
+ KUNIT_EXPECT_EQ(test, vkms_config_plane_attach_crtc(plane_5, crtc_2), 0);
+ KUNIT_EXPECT_EQ(test, vkms_config_plane_attach_crtc(plane_6, crtc_2), 0);
+ KUNIT_EXPECT_EQ(test, vkms_config_plane_attach_crtc(plane_7, crtc_2), 0);
+ KUNIT_EXPECT_EQ(test, vkms_config_plane_attach_crtc(plane_8, crtc_2), 0);
+ KUNIT_EXPECT_EQ(test, vkms_config_plane_attach_crtc(plane_3, crtc_2), 0);
+ KUNIT_EXPECT_EQ(test, vkms_config_plane_attach_crtc(plane_4, crtc_2), 0);
+
+ KUNIT_EXPECT_EQ(test, vkms_config_encoder_attach_crtc(encoder_1, crtc_1), 0);
+ KUNIT_EXPECT_EQ(test, vkms_config_encoder_attach_crtc(encoder_2, crtc_1), 0);
+ KUNIT_EXPECT_EQ(test, vkms_config_encoder_attach_crtc(encoder_3, crtc_1), 0);
+ KUNIT_EXPECT_EQ(test, vkms_config_encoder_attach_crtc(encoder_3, crtc_2), 0);
+ KUNIT_EXPECT_EQ(test, vkms_config_encoder_attach_crtc(encoder_4, crtc_2), 0);
+
+ KUNIT_EXPECT_TRUE(test, vkms_config_is_valid(config));
+
+ vkms_config_delete_plane(plane_4, config);
+ KUNIT_EXPECT_EQ(test, list_count_nodes(&config->planes), 7);
+ KUNIT_EXPECT_EQ(test, list_count_nodes(&config->crtcs), 2);
+ KUNIT_EXPECT_EQ(test, list_count_nodes(&config->encoders), 4);
+
+ KUNIT_EXPECT_TRUE(test, vkms_config_is_valid(config));
+
+ vkms_config_destroy(config);
+}
+
+static struct kunit_case vkms_config_test_cases[] = {
+ KUNIT_CASE(vkms_config_test_basic_allocation),
+ KUNIT_CASE(vkms_config_test_simple_config),
+ KUNIT_CASE(vkms_config_test_complex_config),
+ {}
+};
+
+static struct kunit_suite vkms_config_test_suite = {
+ .name = "vkms-config",
+ .test_cases = vkms_config_test_cases,
+};
+
+kunit_test_suite(vkms_config_test_suite);
+
+MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("Kunit test for vkms config utility");
--
2.47.0
Powered by blists - more mailing lists