linux-kernel - Re: [PATCH v9 17/26] x86/resctrl: Implement resctrl_arch_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8ad51d26-fe26-4fa7-9d20-7e83a9009941@amd.com>
Date: Fri, 22 Nov 2024 18:15:22 -0600
From: "Moger, Babu" <bmoger@....com>
To: Reinette Chatre <reinette.chatre@...el.com>, babu.moger@....com,
 corbet@....net, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com
Cc: fenghua.yu@...el.com, x86@...nel.org, hpa@...or.com, thuth@...hat.com,
 paulmck@...nel.org, rostedt@...dmis.org, akpm@...ux-foundation.org,
 xiongwei.song@...driver.com, pawan.kumar.gupta@...ux.intel.com,
 daniel.sneddon@...ux.intel.com, perry.yuan@....com, sandipan.das@....com,
 kai.huang@...el.com, xiaoyao.li@...el.com, seanjc@...gle.com,
 jithu.joseph@...el.com, brijesh.singh@....com, xin3.li@...el.com,
 ebiggers@...gle.com, andrew.cooper3@...rix.com, mario.limonciello@....com,
 james.morse@....com, tan.shaopeng@...itsu.com, tony.luck@...el.com,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 peternewman@...gle.com, maciej.wieczor-retman@...el.com, eranian@...gle.com,
 jpoimboe@...nel.org, thomas.lendacky@....com
Subject: Re: [PATCH v9 17/26] x86/resctrl: Implement
 resctrl_arch_config_cntr() to assign a counter with ABMC

Hi Reinette,

On 11/22/2024 3:52 PM, Reinette Chatre wrote:
> Hi Babu,
> 
> On 11/22/24 10:54 AM, Moger, Babu wrote:
>> Hi Reinette,
>>
>> On 11/21/2024 2:18 PM, Reinette Chatre wrote:
>>> Hi Babu,
>>>
>>> On 11/19/24 12:12 PM, Moger, Babu wrote:
>>>> Hi Reinette,
>>>>
>>>> On 11/15/24 18:44, Reinette Chatre wrote:
>>>>> Hi Babu,
>>>>>
>>>>> On 10/29/24 4:21 PM, Babu Moger wrote:
>>>>>> The ABMC feature provides an option to the user to assign a hardware
>>>>>> counter to an RMID, event pair and monitor the bandwidth as long as it is
>>>>>> assigned. The assigned RMID will be tracked by the hardware until the user
>>>>>> unassigns it manually.
>>>>>>
>>>>>> Counters are configured by writing to L3_QOS_ABMC_CFG MSR and
>>>>>> specifying the counter id, bandwidth source, and bandwidth types.
>>>>>
>>>>> needs imperative tone
>>>>
>>>> How about this?
>>>>
>>>> Configure the counters by writing to the L3_QOS_ABMC_CFG MSR and
>>>> specifying the counter ID, bandwidth source, and bandwidth types.
>>>>
>>>
>>> ok with me. Exactly what ChatGPT suggests.
>>
>> Hmm. ):
>>
>>>
>>> Please do note that that first paragraph informs reader that
>>> a counter is assigned by user to "an RMID, event pair" while the hardware is configured with
>>> "the counter ID, bandwidth source, and bandwidth types". There thus does not seem
>>> to be a clear connection between what user assigns and what is programmed to hardware.
>>>
>>
>> Adding RMID in the text might help.
>>
>> Configure the counters by writing to the L3_QOS_ABMC_CFG MSR and specifying the counter ID, RMID, bandwidth source, and bandwidth types.
>>
> 
> Isn't the bandwidth source and the RMID the same thing? How about something like:
> "Configure the counters by writing to the L3_QOS_ABMC_CFG MSR and specifying
>   the counter ID, bandwidth source (RMID), and bandwidth event configuration."
> 
> Please feel free to improve.

Looks good. Thanks
-- 
- Babu Moger