linux-kernel - Re: [PATCH] posix-timers: Target group sigqueue to current task only if not exiting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241123101312.GA12843@redhat.com>
Date: Sat, 23 Nov 2024 11:13:12 +0100
From: Oleg Nesterov <oleg@...hat.com>
To: Frederic Weisbecker <frederic@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	Dmitry Vyukov <dvyukov@...gle.com>,
	Anna-Maria Behnsen <anna-maria@...utronix.de>,
	Anthony Mallet <anthony.mallet@...s.fr>
Subject: Re: [PATCH] posix-timers: Target group sigqueue to current task only
 if not exiting

On 11/23, Frederic Weisbecker wrote:
>
> - * the same thread group as the target process, which avoids
> - * unnecessarily waking up a potentially idle task.
> + * the same thread group as the target process and its sighand is
> + * stable, which avoids unnecessarily waking up a potentially idle task.
>   */
>  static inline struct task_struct *posixtimer_get_target(struct k_itimer *tmr)
>  {
>  	struct task_struct *t = pid_task(tmr->it_pid, tmr->it_pid_type);
>  
> -	if (t && tmr->it_pid_type != PIDTYPE_PID && same_thread_group(t, current))
> +	if (t && tmr->it_pid_type != PIDTYPE_PID &&
> +	    same_thread_group(t, current) && !current->exit_state)
>  		t = current;

Thanks!

Acked-by: Oleg Nesterov <oleg@...hat.com>