linux-kernel - Re: [PATCH 1/1] iio: gyro: fxas21002c: Fix missing data update in trigger handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241123154037.05ebcf8a@jic23-huawei>
Date: Sat, 23 Nov 2024 15:40:37 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: Rui Miguel Silva <rmfrfs@...il.com>, Lars-Peter Clausen
 <lars@...afoo.de>, linux-iio@...r.kernel.org (open list:NXP FXAS21002C
 DRIVER), linux-kernel@...r.kernel.org (open list), imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] iio: gyro: fxas21002c: Fix missing data update in
 trigger handler

On Sat, 16 Nov 2024 10:29:45 -0500
Frank Li <Frank.Li@....com> wrote:

> From: Carlos Song <carlos.song@....com>
> 
> The fxas21002c_trigger_handler() may fail to acquire sample data because
> the runtime PM enters the autosuspend state and sensor can not return
> sample data in standby mode..
> 
> Resume the sensor before reading the sample data into the buffer within the
> trigger handler. After the data is read, place the sensor back into the
> autosuspend state.
> 
> Fixes: a0701b6263ae ("iio: gyro: add core driver for fxas21002c")
> Signed-off-by: Carlos Song <carlos.song@....com>
> Signed-off-by: Frank Li <Frank.Li@....com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Note I'll rebase on rc1 once available before sending a pull request with this in.

Thanks,

Jonathan

> ---
>  drivers/iio/gyro/fxas21002c_core.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/gyro/fxas21002c_core.c b/drivers/iio/gyro/fxas21002c_core.c
> index 688966129f704..50b908b2419be 100644
> --- a/drivers/iio/gyro/fxas21002c_core.c
> +++ b/drivers/iio/gyro/fxas21002c_core.c
> @@ -730,14 +730,21 @@ static irqreturn_t fxas21002c_trigger_handler(int irq, void *p)
>  	int ret;
>  
>  	mutex_lock(&data->lock);
> +	ret = fxas21002c_pm_get(data);
> +	if (ret < 0)
> +		goto out_unlock;
> +
>  	ret = regmap_bulk_read(data->regmap, FXAS21002C_REG_OUT_X_MSB,
>  			       data->buffer, CHANNEL_SCAN_MAX * sizeof(s16));
>  	if (ret < 0)
> -		goto out_unlock;
> +		goto out_pm_put;
>  
>  	iio_push_to_buffers_with_timestamp(indio_dev, data->buffer,
>  					   data->timestamp);
>  
> +out_pm_put:
> +	fxas21002c_pm_put(data);
> +
>  out_unlock:
>  	mutex_unlock(&data->lock);
>