linux-kernel - Re: [PATCH v3 10/10] ARM: dts: ti: omap: samsung-espresso10: Add initial support for Galaxy Tab 2 10.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241123175259.775-1-bavishimithil@gmail.com>
Date: Sat, 23 Nov 2024 17:52:58 +0000
From: Mithil Bavishi <bavishimithil@...il.com>
To: andreas@...nade.info
Cc: Laurent.pinchart@...asonboard.com,
	aaro.koskinen@....fi,
	airlied@...il.com,
	bavishimithil@...il.com,
	conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	dri-devel@...ts.freedesktop.org,
	jernej.skrabec@...il.com,
	jonas@...boo.se,
	khilman@...libre.com,
	krzk+dt@...nel.org,
	linux-hardening@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org,
	maarten.lankhorst@...ux.intel.com,
	mripard@...nel.org,
	neil.armstrong@...aro.org,
	prabhakar.mahadev-lad.rj@...renesas.com,
	quic_jesszhan@...cinc.com,
	rfoss@...nel.org,
	robh@...nel.org,
	rogerq@...nel.org,
	simona@...ll.ch,
	thierry.reding@...il.com,
	tony@...mide.com,
	tzimmermann@...e.de
Subject: Re: [PATCH v3 10/10] ARM: dts: ti: omap: samsung-espresso10: Add initial support for Galaxy Tab 2 10.1

> > +&i2c3 {
> > +	touchscreen: synaptics-rmi4-i2c@20 {
>
> touchscreen@20
Fixed, generic node names right!

> > +		avdd-supply = <&reg_touch_ldo_en>;
> not known in schema
I cannot seem to find the "vio-supply" shown in the bindings. There is
only mention of avdd-supply and vdd-supply. I am not sure if avdd and
vio are equivalent, hence the confusion.
What should be the solution here?

> Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml:
> horizontal resolution of touchscreen (maximum x coordinate reported + 1)

> So this touchscreen reports max 1278?

Fixed it as well, 1280 and 800 respectively.
https://github.com/Unlegacy-Android/android_kernel_ti_omap4/blob/3.4/common/arch/arm/mach-omap2/board-espresso-input.c#L264

> And these things belong below rm4-f11 according to
> Documentation/devicetree/bindings/input/syna,rmi4.yaml

I did not quite understand what you mean by this. I checked the bindings 
and a few examples, there is nothing "below" rmi4-f11.

Best Regards,
Mithil