linux-kernel - Re: [PATCH 1/1] nvme: always enable multipath

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <85b9ff69-320a-4b33-bdb2-83882a26d16d@linux.ibm.com>
Date: Sun, 24 Nov 2024 18:39:25 +0530
From: Nilay Shroff <nilay@...ux.ibm.com>
To: John Meneghini <jmeneghi@...hat.com>, Bryan Gurney <bgurney@...hat.com>,
        linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org,
        kbusch@...nel.org, hch@....de, sagi@...mberg.me, axboe@...nel.dk,
        mpe@...erman.id.au, naveen@...nel.org, maddy@...ux.ibm.com,
        kernel@...0n.name
Cc: bmarzins@...hat.com
Subject: Re: [PATCH 1/1] nvme: always enable multipath



On 11/22/24 19:40, John Meneghini wrote:
> On 11/22/24 01:26, Nilay Shroff wrote:
>>  
>> On 11/22/24 03:33, Bryan Gurney wrote:
>>
>> I applied the above changes to my kernel tree and ran the below blktests:
>>
>> # ./check nvme/033 nvme/034 nvme/035 nvme/036 nvme/037 nvme/039
>> nvme/033 => nvme0n1 (tr=loop) (create and connect to an NVMeOF target with a passthru controller) [not run]
>>      /dev/nvme0n1 is a NVMe multipath device
>> nvme/034 => nvme0n1 (tr=loop) (run data verification fio job on an NVMeOF passthru controller) [not run]
>>      /dev/nvme0n1 is a NVMe multipath device
>> nvme/035 => nvme0n1 (tr=loop) (run mkfs and data verification fio job on an NVMeOF passthru controller) [not run]
>>      /dev/nvme0n1 is a NVMe multipath device
>> nvme/036 => nvme0n1 (tr=loop) (test NVMe reset command on an NVMeOF target with a passthru controller) [not run]
>>      /dev/nvme0n1 is a NVMe multipath device
>> nvme/037 => nvme0n1 (tr=loop) (test deletion of NVMeOF passthru controllers immediately after setup) [not run]
>>      /dev/nvme0n1 is a NVMe multipath device
>> nvme/039 => nvme0n1 (test error logging)                     [not run]
>>      /dev/nvme0n1 is a NVMe multipath device
>>
>> As we can see here, the above tests were skipped because the test detects
>> that the device (/dev/nvme0n1) is a multipath device. However, in fact,
>> the test device is NOT a multipath. So I think we need to update the above
>> tests. We may submit another patch to blktest and update above tests once
>> your changes are merged upstream.
> 
> Nilay, what kind of device is /dev/nvme0n1 ?
> 
It's an NVMe namespace attached to a controller. 
> Can you show us the output of
> 
> nvme id-ctrl /dev/nvme0 -H
> nvme id-ns /dev/nvme0n1 -H
> 
Sure, attached the output of above commands for your reference.

Thanks,
--Nilay
View attachment "nvme-id.txt" of type "text/plain" (13087 bytes)