linux-kernel - Re: [PATCH v3 10/10] ARM: dts: ti: omap: samsung-espresso10: Add initial support for Galaxy Tab 2 10.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241124074434.534-1-bavishimithil@gmail.com>
Date: Sun, 24 Nov 2024 07:44:34 +0000
From: Mithil Bavishi <bavishimithil@...il.com>
To: andreas@...nade.info
Cc: Laurent.pinchart@...asonboard.com,
	aaro.koskinen@....fi,
	airlied@...il.com,
	bavishimithil@...il.com,
	conor+dt@...nel.org,
	devicetree@...r.kernel.org,
	dri-devel@...ts.freedesktop.org,
	jernej.skrabec@...il.com,
	jonas@...boo.se,
	khilman@...libre.com,
	krzk+dt@...nel.org,
	linux-hardening@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org,
	maarten.lankhorst@...ux.intel.com,
	mripard@...nel.org,
	neil.armstrong@...aro.org,
	prabhakar.mahadev-lad.rj@...renesas.com,
	quic_jesszhan@...cinc.com,
	rfoss@...nel.org,
	robh@...nel.org,
	rogerq@...nel.org,
	simona@...ll.ch,
	thierry.reding@...il.com,
	tony@...mide.com,
	tzimmermann@...e.de
Subject: Re: [PATCH v3 10/10] ARM: dts: ti: omap: samsung-espresso10: Add initial support for Galaxy Tab 2 10.1

> well, I think I2C bus runs at 1.8V, and there is IO_1.8V in the name,
> so vio-supply should be something at 1.8V, so probably ldo6 is
> vio-supply. Maybe add a remark in the comments. But then it might be
> not a good idea to turn that off in suspend. if the other regulator is
> kept on.

But we are not sure if it is the same, also I personally cannot test it
since I own the 7 inch version. Let's remove avdd supply for now and see
if someone with 10 inch version can test it again later. This is better
than putting potentially incorrect information.

> We have also the warning from dtbs_check:
> arch/arm/boot/dts/ti/omap/omap4-samsung-espresso10.dtb:
> synaptics-rmi4-i2c@20: Unevaluated properties are not allowed
> ('avdd-supply', 'touchscreen-size-x', 'touchscreen-size-y' were
> unexpected)

Ah, indeed. I missed it, will fix it as you've mentioned.

Best Regards,
Mithil