linux-kernel - Re: [PATCH] mm: shmem: Fix variable type to int to evaluate negative conditions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cjg3somsmbqe7e6hllvlmebp7i3uzuajnzihazimiejwnvmjch@v6bmarryiv5w>
Date: Sun, 24 Nov 2024 08:02:06 +0000
From: Karan Sanghavi <karansanghvi98@...il.com>
To: Gabriel Krisman Bertazi <gabriel@...sman.be>, 
	André Almeida <andrealmeid@...lia.com>
Cc: Hugh Dickins <hughd@...gle.com>, 
	Andrew Morton <akpm@...ux-foundation.org>, Christian Brauner <brauner@...nel.org>, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] mm: shmem: Fix variable type to int to evaluate negative
 conditions

On Mon, Nov 11, 2024 at 01:37:43PM -0500, Gabriel Krisman Bertazi wrote:
> Karan Sanghavi <karansanghvi98@...il.com> writes:
> 
> > version variable captures return value from utf8_parse_version
> > function which can be negative, but unsigned won't
> > let it capture, thus missing the further checks on negative values.
> >
> > Fixes: 58e55efd6c72 ("tmpfs: Add casefold lookup support")
> > Signed-off-by: Karan Sanghavi <karansanghvi98@...il.com>
> > ---
> > Coverity Message:
> > CID 1601569: (#1 of 1): Unsigned compared against 0 (NO_EFFECT)
> > unsigned_compare: This less-than-zero comparison of an unsigned 
> > value is never true. version < 0U
> 
> 
> Reviewed-by: Gabriel Krisman Bertazi <gabriel@...sman.be>
> 
> >
> > Coverity Link:
> > https://scan7.scan.coverity.com/#/project-view/10043/11354?selectedIssue=1601569
> > ---
> >  mm/shmem.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mm/shmem.c b/mm/shmem.c
> > index 7987deb2be9b..17a1d4fa8870 100644
> > --- a/mm/shmem.c
> > +++ b/mm/shmem.c
> > @@ -4367,7 +4367,7 @@ static int shmem_parse_opt_casefold(struct fs_context *fc, struct fs_parameter *
> >  				    bool latest_version)
> >  {
> >  	struct shmem_options *ctx = fc->fs_private;
> > -	unsigned int version = UTF8_LATEST;
> > +	int version = UTF8_LATEST;
> >  	struct unicode_map *encoding;
> >  	char *version_str = param->string + 5;
> >  
> >
> > ---
> > base-commit: 6d59cab07b8d74d0f0422b750038123334f6ecc2
> > change-id: 20241111-unsignedcompare1601569-05b5932145ef
> >
> > Best regards,
> 
> -- 
> Gabriel Krisman Bertazi

Dear Gabriel and André,

I hope this email finds you well. 
I'm following up on the patch I had submitted linked below.
https://lore.kernel.org/all/20241111-unsignedcompare1601569-v1-1-c4a9c3c75a52@gmail.com/
I noticed it hasn't been applied yet, and I wanted to see if there was anything 
else needed from my end.
Please let me know if any further information or modifications are required.
I appreciate your time and feedback.  

Thank you!

Sincerely,
Karan.