linux-kernel - Re: [PATCH AUTOSEL 6.12 1/5] uprobes: sanitiize xol_free_insn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z0M1HLLE_ufLcGMO@sashalap>
Date: Sun, 24 Nov 2024 09:15:56 -0500
From: Sasha Levin <sashal@...nel.org>
To: Oleg Nesterov <oleg@...hat.com>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Peter Zijlstra <peterz@...radead.org>, mhiramat@...nel.org,
	mingo@...hat.com, acme@...nel.org, namhyung@...nel.org,
	linux-trace-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.12 1/5] uprobes: sanitiize xol_free_insn_slot()

On Sun, Nov 24, 2024 at 02:13:57PM +0100, Oleg Nesterov wrote:
>Hi Sasha,
>
>but why do you think it makes sense to backport these "uprobes" cleanups?

If it doesn't, I'm happy to drop them. This commit was selected mostly
because of:

>> 1. Clear utask->xol_vaddr unconditionally, even if this addr is not valid,
>>    xol_free_insn_slot() should never return with utask->xol_vaddr != NULL.

Which sounded to me like more than a cleanup.

-- 
Thanks,
Sasha