linux-kernel - Re: [PATCH 2/2] i2c: xiic: Add atomic transfer support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z0NANy2xoSE7TDY3@ninjato>
Date: Sun, 24 Nov 2024 16:03:19 +0100
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Kees Bakker <kees@...erbout.nl>
Cc: Manikanta Guntupalli <manikanta.guntupalli@....com>, git@....com,
	michal.simek@....com, andi.shyti@...nel.org,
	linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, radhey.shyam.pandey@....com,
	srinivas.goud@....com, shubhrajyoti.datta@....com,
	manion05gk@...il.com
Subject: Re: [PATCH 2/2] i2c: xiic: Add atomic transfer support


> > +	while (xiic_rx_space(i2c)) {
> Let's remind what xiic_rx_space is
> #define xiic_rx_space(i2c) ((i2c)->rx_msg->len - (i2c)->rx_pos)
> 
> > +		if (xiic_getreg32(i2c, XIIC_IISR_OFFSET) & XIIC_INTR_RX_FULL_MASK) {
> > +			if (!i2c->rx_msg) {
> This check is suspicious. If i2c->rx_msg is NULL then the while
> above already dereferenced a NULL pointer.
> What is going on?

Valid point. I'll remove the patches from the pull request.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)