linux-kernel - Re: [PATCH] hwmon: (aquacomputer_d5next) Fix length of speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a1bd91e0-ba3b-4262-b7ab-cab8b32795e9@roeck-us.net>
Date: Sun, 24 Nov 2024 07:35:49 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Aleksa Savic <savicaleksa83@...il.com>
Cc: linux-hwmon@...r.kernel.org, Arne Schwabe <arne@...2549.org>,
	Jack Doan <me@...kdoan.com>, Jean Delvare <jdelvare@...e.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (aquacomputer_d5next) Fix length of speed_input
 array

On Sun, Nov 24, 2024 at 04:27:24PM +0100, Aleksa Savic wrote:
> Commit 120584c728a6 ("hwmon: (aquacomputer_d5next) Add support for Octo
> flow sensor") added support for reading Octo flow sensor, but didn't
> update the priv->speed_input array length. Since Octo has 8 fans, with
> the addition of the flow sensor the proper length for speed_input is 9.
> 
> Reported by Arne Schwabe on Github [1], who received a UBSAN warning.
> 
> [1]: https://github.com/aleksamagicka/aquacomputer_d5next-hwmon/issues/100
> 
> Fixes: 120584c728a6 ("hwmon: (aquacomputer_d5next) Add support for Octo flow sensor")
> Reported-by: Arne Schwabe <arne@...2549.org>
> Signed-off-by: Aleksa Savic <savicaleksa83@...il.com>

Applied.

Thanks,
Guenter