linux-kernel - Re: [PATCH] iio: adc: ti-ads1298: Add NULL check in ads1298

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241124175423.5ee15c6a@jic23-huawei>
Date: Sun, 24 Nov 2024 17:54:23 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Charles Han <hanchunchao@...pur.com>, linux-iio@...r.kernel.org, Andy
 Shevchenko <andriy.shevchenko@...ux.intel.com>, Dan Carpenter
 <dan.carpenter@...aro.org>, Lars-Peter Clausen <lars@...afoo.de>, Mike
 Looijmans <mike.looijmans@...ic.nl>, Nuno Sá
 <nuno.sa@...log.com>, Alexander Viro <viro@...iv.linux.org.uk>, Yu
 Jiaoliang <yujiaoliang@...o.com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: adc: ti-ads1298: Add NULL check in ads1298_init()

On Mon, 18 Nov 2024 11:08:47 +0100
Markus Elfring <Markus.Elfring@....de> wrote:

> > devm_kasprintf() can return a NULL pointer on failure,but this
> > returned value in ads1298_init() is not checked.
> > Add NULL check in ads1298_init(), to handle kernel NULL
> > pointer dereference error.  
> 
> Another wording suggestion:
> A devm_kasprintf() call can return a null pointer on failure.
> But such a return value was not checked in this function implementation.
> Thus add a corresponding check so that a null pointer dereference
> will be avoided.
> 
> 
> Regards,
> Markus

I tweaked it to slightly shorter form.

Applied and marked for stable.

Thanks,

Jonathan