linux-kernel - Re: [PATCH v2 01/22] iio: accel: adxl345: fix comment on probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241124175757.3fe3c0ea@jic23-huawei>
Date: Sun, 24 Nov 2024 17:57:57 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Lothar Rubusch <l.rubusch@...il.com>
Cc: lars@...afoo.de, Michael.Hennerich@...log.com,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 eraretuya@...il.com
Subject: Re: [PATCH v2 01/22] iio: accel: adxl345: fix comment on probe

On Sun, 17 Nov 2024 18:26:30 +0000
Lothar Rubusch <l.rubusch@...il.com> wrote:

> Fix comment on the probe function. Add covered sensors and fix typo.
> 
> Signed-off-by: Lothar Rubusch <l.rubusch@...il.com>
> ---
>  drivers/iio/accel/adxl345_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/accel/adxl345_core.c b/drivers/iio/accel/adxl345_core.c
> index 006ce66c0a..d121caf839 100644
> --- a/drivers/iio/accel/adxl345_core.c
> +++ b/drivers/iio/accel/adxl345_core.c
> @@ -170,7 +170,7 @@ static void adxl345_powerdown(void *regmap)
>  
>  /**
>   * adxl345_core_probe() - probe and setup for the adxl345 accelerometer,
> - *                        also covers the adlx375 accelerometer
> + *                        also covers the adxl375 and adxl346 accelerometer
This is too easy to miss updating and to my eyes it doesn't makes sense to
have the list here. How about,

probe and setup for the supported accelerometers.
of just
probe and setup for the accelerometer.

>   * @dev:	Driver model representation of the device
>   * @regmap:	Regmap instance for the device
>   * @setup:	Setup routine to be executed right before the standard device