linux-kernel - Re: [PATCH v2 05/22] iio: accel: adxl345: measure right-justified

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241124180733.2925eaa7@jic23-huawei>
Date: Sun, 24 Nov 2024 18:07:33 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Lothar Rubusch <l.rubusch@...il.com>
Cc: lars@...afoo.de, Michael.Hennerich@...log.com,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 eraretuya@...il.com
Subject: Re: [PATCH v2 05/22] iio: accel: adxl345: measure right-justified

On Sun, 17 Nov 2024 18:26:34 +0000
Lothar Rubusch <l.rubusch@...il.com> wrote:

> Make measurements right-justified, since it is the default for the
> driver and sensor. By not setting the ADXL345_DATA_FORMAT_JUSTIFY bit,
> the data becomes right-judstified. This was the original setting, there
> is no reason to change it to left-justified, where right-justified
> simplifies working on the registers.

Surely this can't be changed independent of other changes as it will
change the format of the data we are processing?

Each change must stand on it's own so that I can apply up to any
point in your patch set and have everything continue to work.


Jonathan

> Signed-off-by: Lothar Rubusch <l.rubusch@...il.com>
> ---
>  drivers/iio/accel/adxl345_core.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/accel/adxl345_core.c b/drivers/iio/accel/adxl345_core.c
> index 2b62e79248..926e397678 100644
> --- a/drivers/iio/accel/adxl345_core.c
> +++ b/drivers/iio/accel/adxl345_core.c
> @@ -184,8 +184,13 @@ int adxl345_core_probe(struct device *dev, struct regmap *regmap,
>  	struct adxl34x_state *st;
>  	struct iio_dev *indio_dev;
>  	u32 regval;
> +
> +	/* NB: ADXL345_DATA_FORMAT_JUSTIFY or 0:
	/*
	 * NB: AD...

is the multiline comment style all IIO drivers use (and most of the kernel
except for networking.

> +	 * do right-justified: 0, then adjust resolution according to 10-bit
> +	 * through 13-bit in channel - this is the default behavior, and can
> +	 * be modified here by oring ADXL345_DATA_FORMAT_JUSTIFY
> +	 */
>  	unsigned int data_format_mask = (ADXL345_DATA_FORMAT_RANGE |
> -					 ADXL345_DATA_FORMAT_JUSTIFY |
>  					 ADXL345_DATA_FORMAT_FULL_RES |
>  					 ADXL345_DATA_FORMAT_SELF_TEST);
>  	int ret;