linux-kernel - Re: [PATCH] kprobes: Reduce preempt disable scope in check_kprobe_access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241125142458.9ed23f07da4eaf732cfa9a8e@kernel.org>
Date: Mon, 25 Nov 2024 14:24:58 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 Naveen N Rao <naveen@...nel.org>, Anil S Keshavamurthy
 <anil.s.keshavamurthy@...el.com>, "David S. Miller" <davem@...emloft.net>,
 Masami Hiramatsu <mhiramat@...nel.org>, Clark Williams
 <clrkwllms@...nel.org>, Steven Rostedt <rostedt@...dmis.org>,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 linux-rt-devel@...ts.linux.dev
Subject: Re: [PATCH] kprobes: Reduce preempt disable scope in
 check_kprobe_access_safe()

On Thu, 21 Nov 2024 09:04:32 +0100
Sebastian Andrzej Siewior <bigeasy@...utronix.de> wrote:

> On 2024-11-21 08:38:08 [+0100], Thomas Weißschuh wrote:
> …
> > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> 
> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Thanks for your review!

> 
> > diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> > index da59c68df8412c4662d39d3e286d516e8cee9a69..369020170e832a34ea9c05eda6693bded02ec505 100644
> > --- a/kernel/kprobes.c
> > +++ b/kernel/kprobes.c
> > @@ -39,6 +39,7 @@
> >  #include <linux/static_call.h>
> >  #include <linux/perf_event.h>
> >  #include <linux/execmem.h>
> > +#include <linux/cleanup.h>
> 
> This hunk can be dropped. The definition for guard(preempt)() comes from
> preempt.h.
> 
> >  #include <asm/sections.h>
> >  #include <asm/cacheflush.h>
> 
> Sebastian

-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>