linux-kernel - Re: [PATCH] scsi: ufs: core: Fix link_startup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b0917952-c5ab-4774-b232-8b626a7a3b97@acm.org>
Date: Mon, 25 Nov 2024 09:10:20 -0800
From: Bart Van Assche <bvanassche@....org>
To: Vamshi Gajjela <vamshigajjela@...gle.com>,
 Alim Akhtar <alim.akhtar@...sung.com>, Avri Altman <avri.altman@....com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: ufs: core: Fix link_startup_again on success

On 11/25/24 4:53 AM, Vamshi Gajjela wrote:
> Set link_startup_again to false after a successful
> ufshcd_dme_link_startup operation and confirmation of device presence.
> Prevents unnecessary link startup attempts when the previous operation
> has succeeded.
> 
> Signed-off-by: Vamshi Gajjela <vamshigajjela@...gle.com>
> Fixes: 7caf489b99a4 ("scsi: ufs: issue link starup 2 times if device isn't active")
> Cc: stable@...r.kernel.org

Shouldn't your Signed-off-by come after the Fixes: and Cc: stable tags? 
Anyway, since this patch looks good to me:

Reviewed-by: Bart Van Assche <bvanassche@....org>