linux-kernel - Re: [PATCH v2 2/2] efi/fdt: ignore dtb when acpi option is used with force

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <458d865b-5e3f-4c5b-94b3-8f4368d27677@sirena.org.uk>
Date: Mon, 25 Nov 2024 17:18:14 +0000
From: Mark Brown <broonie@...nel.org>
To: Yeoreum Yun <yeoreum.yun@....com>
Cc: ardb@...nel.org, sami.mujawar@....com, sudeep.holla@....com,
	pierre.gondois@....com, hagarhem@...zon.com,
	catalin.marinas@....com, will@...nel.org, guohanjun@...wei.com,
	Jonathan.Cameron@...wei.com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org
Subject: Re: [PATCH v2 2/2] efi/fdt: ignore dtb when acpi option is used with
 force

On Mon, Nov 25, 2024 at 05:07:58PM +0000, Yeoreum Yun wrote:

>  	unsigned long fdt_addr = 0;
>  	unsigned long fdt_size = 0;
> +	bool acpi_force = false;
> +
> 

Extra blank line added here.

>  	if (!IS_ENABLED(CONFIG_EFI_ARMSTUB_DTB_LOADER) ||
> -	    efi_get_secureboot() != efi_secureboot_mode_disabled) {
> +	    efi_get_secureboot() != efi_secureboot_mode_disabled ||
> +			acpi_force) {

Should this line be aligned with the prior one?

The actual change looks sensible to me.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)