[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <562bdcfd-1595-422a-884b-09c36db72737@oldschoolsolutions.biz>
Date: Mon, 25 Nov 2024 19:25:39 +0100
From: Jens Glathe <jens.glathe@...schoolsolutions.biz>
To: Doug Anderson <dianders@...omium.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Neil Armstrong <neil.armstrong@...aro.org>,
Jessica Zhang <quic_jesszhan@...cinc.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Kalle Valo <kvalo@...nel.org>, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 3/4] drm/panel-edp: Add unknown BOE panel for HP Omnibook
X14
Hi Doug,
On 25.11.24 18:53, Doug Anderson wrote:
> Hi,
>
> On Sun, Nov 24, 2024 at 5:20 AM Jens Glathe via B4 Relay
> <devnull+jens.glathe.oldschoolsolutions.biz@...nel.org> wrote:
>> From: Jens Glathe <jens.glathe@...schoolsolutions.biz>
>>
>> [...]
>>
>> There are no timings in it, sadly.
> Yeah, and like other BOE panels also no model info in the EDID. Sigh.
> I guess "Unknown" it is until someone can officially add it.
>
>
>> Signed-off-by: Jens Glathe <jens.glathe@...schoolsolutions.biz>
>> ---
>> drivers/gpu/drm/panel/panel-edp.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
>> index 8566e9cf2f82a..403679e506fa4 100644
>> --- a/drivers/gpu/drm/panel/panel-edp.c
>> +++ b/drivers/gpu/drm/panel/panel-edp.c
>> @@ -1915,6 +1915,7 @@ static const struct edp_panel_entry edp_panels[] = {
>> EDP_PANEL_ENTRY('B', 'O', 'E', 0x0c20, &delay_200_500_e80, "NT140FHM-N47"),
>> EDP_PANEL_ENTRY('B', 'O', 'E', 0x0cb6, &delay_200_500_e200, "NT116WHM-N44"),
>> EDP_PANEL_ENTRY('B', 'O', 'E', 0x0cfa, &delay_200_500_e50, "NV116WHM-A4D"),
>> + EDP_PANEL_ENTRY('B', 'O', 'E', 0x0c93, &delay_200_500_e200, "Unknown"),
> This is sorted incorrectly. I'll fix it for you this time while
> applying, but in the future make sure you sort numerically. 0x0c93
> should be before 0x0cb6.
>
Thank you, haven't seen it. I would have reordered it in V2, but now it
stays that way. Yay!
with best regards
Jens
> Reviewed-by: Douglas Anderson <dianders@...omium.org>
>
> Pushed to drm-misc-next:
>
> [3/4] drm/panel-edp: Add unknown BOE panel for HP Omnibook X14
> commit: c1bae6802ee9c8ad8e3c1df7ca3174d6b4b260e5
Powered by blists - more mailing lists