linux-kernel - Re: [PATCH v2] mm/damon/core: remove duplicate list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20241125184307.41746-1-sj@kernel.org>
Date: Mon, 25 Nov 2024 10:43:07 -0800
From: SeongJae Park <sj@...nel.org>
To: Honggyu Kim <honggyu.kim@...com>
Cc: SeongJae Park <sj@...nel.org>,
	damon@...ts.linux.dev,
	kernel_team@...ynix.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm/damon/core: remove duplicate list_empty quota->goals check

On Mon, 25 Nov 2024 13:56:55 +0900 Honggyu Kim <honggyu.kim@...com> wrote:

> The damos_set_effective_quota checks quota contidions but there are some
> duplicate checks for quota->goals inside.
> 
> This patch reduces one of if statement to simplify the esz calculation
> logic by setting esz as ULONG_MAX by default.
> 
> Signed-off-by: Honggyu Kim <honggyu.kim@...com>

Reviewed-by: SeongJae Park <sj@...nel.org>

> ---
>  mm/damon/core.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index 511c3f61ab44..ecaf78270035 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -1542,7 +1542,7 @@ static unsigned long damos_quota_score(struct damos_quota *quota)
>  static void damos_set_effective_quota(struct damos_quota *quota)
>  {
>  	unsigned long throughput;
> -	unsigned long esz;
> +	unsigned long esz = ULONG_MAX;
>  
>  	if (!quota->ms && list_empty(&quota->goals)) {
>  		quota->esz = quota->sz;
> @@ -1564,10 +1564,7 @@ static void damos_set_effective_quota(struct damos_quota *quota)
>  				quota->total_charged_ns;
>  		else
>  			throughput = PAGE_SIZE * 1024;
> -		if (!list_empty(&quota->goals))
> -			esz = min(throughput * quota->ms, esz);
> -		else
> -			esz = throughput * quota->ms;
> +		esz = min(throughput * quota->ms, esz);
>  	}
>  
>  	if (quota->sz && quota->sz < esz)
> 
> base-commit: adc218676eef25575469234709c2d87185ca223a
> -- 
> 2.34.1

Thank you for addressing my comments on the v1
(https://lore.kernel.org/20241122081834.1344-1-honggyu.kim@sk.com), namely
- making commit message more specific, and
- using ULONG_MAX instead of UINT_MAX for esz default value.


Thanks,
SJ