linux-kernel - Re: [PATCH 1/2] dt-bindings: hwmon: (pmbus/adp1050): Add bindings for adp1051, adp1055 and ltp8800

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241125-clever-unpeeled-61362034cf24@spud>
Date: Mon, 25 Nov 2024 18:48:30 +0000
From: Conor Dooley <conor@...nel.org>
To: "Encarnacion, Cedric justine" <Cedricjustine.Encarnacion@...log.com>
Cc: Guenter Roeck <linux@...ck-us.net>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
	Jean Delvare <jdelvare@...e.com>, Jonathan Corbet <corbet@....net>,
	Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	"Sabau, Radu bogdan" <Radu.Sabau@...log.com>,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	"Torreno, Alexis Czezar" <AlexisCzezar.Torreno@...log.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: (pmbus/adp1050): Add bindings
 for adp1051, adp1055 and ltp8800

On Mon, Nov 25, 2024 at 02:44:32AM +0000, Encarnacion, Cedric justine wrote:
> > On Sat, Nov 23, 2024 at 07:56:21PM +0000, Conor Dooley wrote:
> > > On Wed, Nov 20, 2024 at 10:00:19AM -0800, Guenter Roeck wrote:
> > > > On 11/20/24 09:11, Conor Dooley wrote:
> > > > > On Wed, Nov 20, 2024 at 11:58:25AM +0800, Cedric Encarnacion wrote:
> > > > > > add dt-bindings for adp1051, adp1055, and ltp8800 pmbus.
> > > > > >      ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature
> > > > > >      ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature
> > > > > >      LTP8800-1A/-2/-4A: 150A/135A/200A DC/DC µModule Regulator
> > > > > >
> > > > > > Co-developed-by: Alexis Czezar Torreno
> > <alexisczezar.torreno@...log.com>
> > > > > > Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@...log.com>
> > > > > > Signed-off-by: Cedric Encarnacion
> > <cedricjustine.encarnacion@...log.com>
> > > > >
> > > > > Why did you drop my ack?
> > > > > https://lore.kernel.org/all/20241106-linoleum-kebab-
> > decf14f54f76@...d/
> > > > >
> > > >
> > > > There:
> > > >
> > > > > +    enum:
> > > > > +      - adi,adp1050
> > > > > +      - adi,adp1051
> > > > > +      - adi,adp1055
> > > > >
> > > >
> > > > Here:
> > > >
> > > > >> +    enum:
> > > > >> +      - adi,adp1050
> > > > >> +      - adi,adp1051
> > > > >> +      - adi,adp1055
> > > > >> +      - adi,ltp8800   <--
> > > >
> > > > This is a combination of two patch series. I'd personally hesitant to carry
> > > > Acks along in such situations.
> > >
> > > Ah, I didn't notice that. Thanks for pointing it out. Cedric, in the
> > > future please mention things like this if you drop an ack.
> > 
> > Whoops, forgot to mention that Cedric can grab the ack from the link
> > above when they resubmit.
> 
> Okay. I will be carrying on acks in the future for cases like this.

I mean, I don't disagree with Guenter that in this case he would
hesitate to carry the ack as I probably would drop it too.
The difference compared to what happened here is that I would mention
/why/ I dropped it.
If you're going to carry it while merging two series and resetting the
patch number, it's good to reference where you got the ack from to
avoid confusing people, particularly given the patch was modified
compared to what got acked.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)