[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <523727cd-7950-45b1-a0d3-3f978e789015@kernel.org>
Date: Mon, 25 Nov 2024 21:01:18 +0200
From: Roger Quadros <rogerq@...nel.org>
To: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Siddharth Vadapalli <s-vadapalli@...com>, "srk@...com" <srk@...com>,
"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: dwc3: dwc3-am62: Re-initialize controller if lost
power in PM suspend
On 25/11/2024 20:23, Thinh Nguyen wrote:
> On Fri, Nov 22, 2024, Roger Quadros wrote:
>> If controller looses power during PM suspend then re-initialize
>> it. We use the DEBUG_CFG register to track if controller lost power
>> or was reset in PM suspend.
>>
>> Move all initialization code into dwc3_ti_init() so it can be re-used.
>>
>> Signed-off-by: Roger Quadros <rogerq@...nel.org>
>> ---
>> drivers/usb/dwc3/dwc3-am62.c | 82 +++++++++++++++++++++++++++++---------------
>> 1 file changed, 55 insertions(+), 27 deletions(-)
>>
>> diff --git a/drivers/usb/dwc3/dwc3-am62.c b/drivers/usb/dwc3/dwc3-am62.c
>> index fad151e78fd6..2192222faf4f 100644
>> --- a/drivers/usb/dwc3/dwc3-am62.c
>> +++ b/drivers/usb/dwc3/dwc3-am62.c
>> @@ -108,6 +108,9 @@
>>
>> #define DWC3_AM62_AUTOSUSPEND_DELAY 100
>>
>> +#define USBSS_DEBUG_CFG_OFF 0x7
>> +#define USBSS_DEBUG_CFG_DISABLED 0x7
>
> Do we need 2 different macros with the same value of the same register
> for this?
Oops. This is a mistake. The second one should be 0.
--
cheers,
-roger
Powered by blists - more mailing lists