linux-kernel - Re: [PROBLEM] make bindeb-pkg: When just one source line in a single driver is changed, all driver are rebuilt?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d136d201-7aa5-4bab-8437-c44e0c54e0e4@gmail.com>
Date: Mon, 25 Nov 2024 20:10:42 +0100
From: Mirsad Todorovac <mtodorovac69@...il.com>
To: Thomas Weißschuh <thomas@...ch.de>
Cc: Linux Kernel Build System <linux-kbuild@...r.kernel.org>,
 Masahiro Yamada <masahiroy@...nel.org>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Bagas Sanjaya <bagasdotme@...il.com>
Subject: Re: [PROBLEM] make bindeb-pkg: When just one source line in a single
 driver is changed, all driver are rebuilt?

On 11/23/24 15:57, Thomas Weißschuh wrote:
> Hi Mirsad,
> 
> On 2024-11-23 02:53:09+0100, Mirsad Todorovac wrote:
>> Hi, Mr. Weißschuh,
> 
> Call me Thomas, please :-)

It will be my honour, thanks :-)

>> On 11/21/24 22:43, Thomas Weißschuh wrote:
>>
>>> On 2024-11-21 22:18:58+0100, Mirsad Todorovac wrote:
>>>> I am perplexed now at 6.12 stable vanilla tree, and I've noticed that after changing just one
>>>> line in ./drivers/gpu/drm/xe/tests/xe_migrate.c:226:5-11, all unrelated drivers are being BTF'd, SIGNED,
>>>> and INSTALL-ed:
>>>>
>>>>   SIGN    debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/aht10.ko
>>>>   INSTALL debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/coretemp.ko
>>>>   STRIP   debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/atxp1.ko
>>>>   INSTALL debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/corsair-cpro.ko
>>>>   SIGN    debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/adt7475.ko
>>>>   STRIP   debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/axi-fan-control.ko
>>>>   SIGN    debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/as370-hwmon.ko
>>>>   STRIP   debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/chipcap2.ko
>>>>   SIGN    debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/aquacomputer_d5next.ko
>>>>   STRIP   debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/coretemp.ko
>>>>   SIGN    debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/applesmc.ko
>>>>   INSTALL debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/corsair-psu.ko
>>>>   STRIP   debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/corsair-cpro.ko
>>>>   SIGN    debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/asus_rog_ryujin.ko
>>>>   INSTALL debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/cros_ec_hwmon.ko
>>>>   SIGN    debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/asc7621.ko
>>>>   INSTALL debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/da9052-hwmon.ko
>>>>   SIGN    debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/atxp1.ko
>>>>   SIGN    debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/axi-fan-control.ko
>>>>   STRIP   debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/corsair-psu.ko
>>>>   INSTALL debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/da9055-hwmon.ko
>>>>   SIGN    debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/chipcap2.ko
>>>>   STRIP   debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/cros_ec_hwmon.ko
>>>>   STRIP   debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/da9052-hwmon.ko
>>>>   SIGN    debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/coretemp.ko
>>>>   SIGN    debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/corsair-cpro.ko
>>>>   INSTALL debian/linux-image-6.12.0-dirty/lib/modules/6.12.0-dirty/kernel/drivers/hwmon/dell-smm-hwmon.ko
>>> This happens when the vermagic is changed. The vermagic is linked into
>>> each module. And after relinking all the other steps also need to be
>>> done.
>>> Building the Debian package increases the build number which ends up in
>>> the vermagic and therefore all modules.
>>> Also there is CONFIG_LOCALVERSION_AUTO which may be involved.
>>
>> Yes, I use CONFIG_LOCALVERSION_AUTO because it saves a lot of trouble in bisecting.
>>
>> This vermagic manipulation is beyond my grasp. I understand that
>> modules must match kernel version, for internal ABI often changes. But
>> not between builds of the same source? Am I thinking right?
> 
> The ABI doesn't change between builds of the same source tree which is
> why there are no actual rebuilds ("CC") of all modules.

That is actually more precise.

> But your usage of bindeb-pkg bumps the version string
> (also without CONFIG_LOCALVERSION_AUTO) and this needs to end up in each
> module file which explains the LD/BTF/SIGN/INSTALL steps.

I see. I hoped there is a way around this.

CONFIG_LOCALVERSION_AUTO is very useful when compared to manually keeping tracks of commits.

Once upon a time, about a year or two ago, I told Mr. Bagas Sanjaya how a list of applied diffs
could be added to the kernel manifest instead of just config-${VERSION} and "-dirty" flag.

Thanks.

Best regards,
Mirsad

> [..]