linux-kernel - Re: [PATCH v2 1/3] iio: adc: ad4695: fix buffered read, single sample timings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <23038c4b-9f9d-4a47-8c28-89893027322f@baylibre.com>
Date: Mon, 25 Nov 2024 15:32:53 -0500
From: Trevor Gamblin <tgamblin@...libre.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: Lars-Peter Clausen <lars@...afoo.de>,
 Michael Hennerich <Michael.Hennerich@...log.com>,
 Nuno Sá <nuno.sa@...log.com>,
 David Lechner <dlechner@...libre.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] iio: adc: ad4695: fix buffered read, single sample
 timings


On 2024-11-24 07:52, Jonathan Cameron wrote:
> On Wed, 13 Nov 2024 15:52:58 -0500
> Trevor Gamblin <tgamblin@...libre.com> wrote:
>
>> Modify ad4695_buffer_preenable() by adding an extra SPI transfer after
>> each data read to help ensure that the timing requirement between the
>> last SCLK rising edge and the next CNV rising edge is met. This requires
>> a restructure of the buf_read_xfer array in ad4695_state. Also define
>> AD4695_T_SCK_CNV_DELAY_NS to use for each added transfer. Without this
>> change it is possible for the data to become corrupted on sequential
>> buffered reads due to the device not properly exiting conversion mode.
>>
>> Similarly, make adjustments to ad4695_read_one_sample() so that timings
>> are respected, and clean up the function slightly in the process.
>>
>> Fixes: 6cc7e4bf2e08 ("iio: adc: ad4695: implement triggered buffer")
>> Co-developed-by: David Lechner <dlechner@...libre.com>
>> Signed-off-by: David Lechner <dlechner@...libre.com>
>> Signed-off-by: Trevor Gamblin <tgamblin@...libre.com>
>> ---
> Applied to the fixes-togreg branch of iio.git. I'll rebase that
> and send out a pull shortly after rc1.
>
> The other two will have to wait for that to cycle around to be
> in the upstream for my togreg branch later in the cycle.
>
> Thanks,
>
> Jonathan
Thank you!