linux-kernel - Re: [PATCH for-next v4] selftests/mm: Add a few missing gitignore files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c737c8f8-5fd5-4acd-aba9-787009a8497c@nvidia.com>
Date: Mon, 25 Nov 2024 12:38:49 -0800
From: John Hubbard <jhubbard@...dia.com>
To: Li Zhijian <lizhijian@...itsu.com>, shuah@...nel.org,
 linux-kselftest@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Donet Tom <donettom@...ux.ibm.com>,
 Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
 kernel test robot <lkp@...el.com>
Subject: Re: [PATCH for-next v4] selftests/mm: Add a few missing gitignore
 files

On 11/24/24 10:40 PM, Li Zhijian wrote:
> Compiled binary files should be added to .gitignore
> 'git status' complains:
>     Untracked files:
>     (use "git add <file>..." to include in what will be committed)
>           mm/hugetlb_dio
>           mm/pkey_sighandler_tests_32
>           mm/pkey_sighandler_tests_64
> 
> Cc: Donet Tom <donettom@...ux.ibm.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Shuah Khan <shuah@...nel.org>
> Signed-off-by: Li Zhijian <lizhijian@...itsu.com>
> Reviewed-by: John Hubbard <jhubbard@...dia.com>
> ---
> Cc: linux-mm@...ck.org
> ---
> 
> Hey John,
> I added your Reviewed-by tag in this revision which have a minor
> updates. Feel free to let me know if you feel this is unsuitable.
> 
> Hello,
> Cover letter is here.
> 
> This patch set aims to make 'git status' clear after 'make' and 'make
> run_tests' for kselftests.
> ---
> V4:
> 
>    Use the exact filename to fix warning reported by lkp@...el.com
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202411251308.Vjm5MzVC-lkp@intel.com/
> V3:
>     nothing change, just resend it
>     (This .gitignore have not sorted, so I appended new files to the end)
> V2:
>    split as seperate patch from a small one [0]
>    [0] https://lore.kernel.org/linux-kselftest/20241015010817.453539-1-lizhijian@fujitsu.com/
> ---
>   tools/testing/selftests/mm/.gitignore | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
> index da030b43e43b..689bbd520296 100644
> --- a/tools/testing/selftests/mm/.gitignore
> +++ b/tools/testing/selftests/mm/.gitignore
> @@ -51,3 +51,6 @@ hugetlb_madv_vs_map
>   mseal_test
>   seal_elf
>   droppable
> +hugetlb_dio
> +pkey_sighandler_tests_32
> +pkey_sighandler_tests_64

Makes sense. Yes, this still looks good.

thanks,
-- 
John Hubbard