linux-kernel - Re: [PATCH] regmap: detach regmap from dev on regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2da70bdc-97d5-4bef-bb66-3becf40c54ec@gmail.com>
Date: Mon, 25 Nov 2024 22:44:06 +0200
From: Cosmin Tanislav <demonsingur@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J . Wysocki" <rafael@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: detach regmap from dev on regmap_exit

On 11/25/24 2:22 PM, Mark Brown wrote:
> On Fri, Nov 22, 2024 at 05:16:30PM +0200, Cosmin Tanislav wrote:
> 
>> +int regmap_detach_dev(struct device *dev, struct regmap *map)
>> +{
>> +	if (!dev)
>> +		return 0;
>> +
>> +	return devres_release(dev, dev_get_regmap_release,
>> +			      dev_get_regmap_match, (void *)map->name);
>> +}
>> +EXPORT_SYMBOL_GPL(regmap_detach_dev);
> 
> Why is this exported?
> 

I only did it because regmap_attach_dev() was also exported.
I can make it static for V2.

>> @@ -1445,6 +1457,7 @@ void regmap_exit(struct regmap *map)
>>   {
>>   	struct regmap_async *async;
>>   
>> +	regmap_detach_dev(map->dev, map);
>>   	regcache_exit(map);
>>   
>>   	regmap_debugfs_exit(map);
> 
> The one caller is in the same file so it can be static.