linux-kernel - Re: [PATCH v5 3/4] scsi: ufs: core: Introduce a new clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ee1eaed1-3ce5-4037-a385-18febab695a0@acm.org>
Date: Mon, 25 Nov 2024 13:35:45 -0800
From: Bart Van Assche <bvanassche@....org>
To: Avri Altman <avri.altman@....com>,
 "Martin K . Petersen" <martin.petersen@...cle.com>
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
 Bean Huo <beanhuo@...ron.com>
Subject: Re: [PATCH v5 3/4] scsi: ufs: core: Introduce a new clock_gating lock

On 11/23/24 11:08 PM, Avri Altman wrote:
> Introduce a new clock gating lock to serialize access to some of the
> clock gating members instead of the host_lock.
> 
> While at it, simplify the code with the guard() macro and co for
> automatic cleanup of the new lock. There are some explicit
> spin_lock_irqsave/spin_unlock_irqrestore snaking instances I left behind
> because I couldn't make heads or tails of it.
> 
> Additionally, move the trace_ufshcd_clk_gating() call from inside the
> region protected by the lock as it doesn't needs protection.

Reviewed-by: Bart Van Assche <bvanassche@....org>