linux-kernel - Re: uprobe_events can't accept paths that contain spaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20241125154356.1e44f3c5775bb30269ed28a5@kernel.org>
Date: Mon, 25 Nov 2024 15:43:56 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Yuxuan Shui <yshuiv7@...il.com>
Cc: linux-trace-kernel@...r.kernel.org, Steven Rostedt
 <rostedt@...dmis.org>, Masami Hiramatsu <mhiramat@...nel.org>, Mathieu
 Desnoyers <mathieu.desnoyers@...icios.com>, open list
 <linux-kernel@...r.kernel.org>
Subject: Re: uprobe_events can't accept paths that contain spaces

On Fri, 22 Nov 2024 00:42:51 +0000
Yuxuan Shui <yshuiv7@...il.com> wrote:

> Hi,
> 
> I hit this problem accidentally when one of the shared libraries I was
> looking at is located in a directory with spaces in its name. `perf
> probe` reported "Failed to write event: Invalid argument".

Oops, yes, it is limited by implementation.

> 
> If I understand the code correctly, strings written into uprobe_events
> are strictly splitted at whitespaces (by `argv_split`).

Right!

> This seems
> like an unfortunate restriction. If I submit a patch to introduce
> support for either quotes (") or escapes (\), will that be considered?

Yeah, that enhancement is welcome! You can add such function in
trace_probe.c and use it instead of argv_split.

> 
> (For context I am running something that expects its libraries to be
> located at fixed paths, so moving them to a different path would be
> awkward at best.)

Thanks,

> 
> Thanks.
> 
> -- 
> 
> Regards
> Yuxuan Shui


-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>