linux-kernel - Re: [PATCH 5/5] nvme-tcp: fix the memleak while create new ctrl failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241125072533.GE15647@lst.de>
Date: Mon, 25 Nov 2024 08:25:33 +0100
From: Christoph Hellwig <hch@....de>
To: "brookxu.cn" <brookxu.cn@...il.com>
Cc: kbusch@...nel.org, axboe@...nel.dk, hch@....de, sagi@...mberg.me,
	linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] nvme-tcp: fix the memleak while create new ctrl
 failed

On Sat, Nov 23, 2024 at 09:37:41PM +0800, brookxu.cn wrote:
> From: "Chunguang.xu" <chunguang.xu@...pee.com>
> 
> Now while we create new ctrl failed, we have not free the
> tagset occupied by admin_q, here try to fix it.

Looks good:

Reviewed-by: Christoph Hellwig <hch@....de>

but please add a Fixes tag and move it to the beginning of the series.