linux-kernel - Re: [PATCH 1/6] dt-bindings: display: panel: Add another panel for RG35XX Plus (Rev6)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d1e8b3e9-526d-4910-8b15-6cce2c8526db@kernel.org>
Date: Mon, 25 Nov 2024 08:38:55 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Hironori KIKUCHI <kikuchan98@...il.com>
Cc: linux-kernel@...r.kernel.org, Neil Armstrong <neil.armstrong@...aro.org>,
 Jessica Zhang <quic_jesszhan@...cinc.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Paul Cercueil <paul@...pouillou.net>,
 Christophe Branchereau <cbranchereau@...il.com>,
 Ryan Walklin <ryan@...ttoast.com>, dri-devel@...ts.freedesktop.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: display: panel: Add another panel for
 RG35XX Plus (Rev6)

On 24/11/2024 20:14, Hironori KIKUCHI wrote:
> Hello Krzysztof,
> 
> Thank you for reviewing.
> 
>> no wildcards
> 
> Sorry, but I believe these are not wildcards.
> 
> As discussed previously, the integrating vendor and device name are
> preferred instead of the OEM serial for unidentified OEM panels.
> These compatible strings are based on the actual device names:
>   "RG35XX Plus", "RG 40XXV", "RG40XX H", and "RG CubeXX"
> You can refer to
> https://anbernic.com/collections/handheld-game-console for the full


Then explain this in commit msg.

> line-up.
> 
> Oh, regarding "rg40xx-panel", it might have been separated to
> "rg40xx-v-panel" and "rg40xx-h-panel".
> 
> 
>> don't duplicate schemas
> 
> The old schemas "leadtek,ltk035c5444t", "fascontek,fs035vg158", and
> "anbernic,rg35xx-plus-panel" exist independently.


So you duplicate them. I wrote: Don't duplicate.

> So I had to add new schemas since the new ones are not compatible with
> the old ones.

No, you do not have to. There is no such thing as schema compatible with
schema.


> 
> Perhaps the compatibles should be like this:
>   compatible = "anbernic,rg35xx-plus-panel", "newvision,nv3052c";
> as some others do.

We do not talk about compatibles.

> 
> In this way, the schema files would be a single file and not be messed
> up, but it would break the previously defined schemas.


What? No, it would not  break. Don't touch existing compatibles.

> 
> How should I deal with this?
> Any suggestions or advice would be greatly appreciated.

The same as with all other changes: add to existing files.

Best regards,
Krzysztof