linux-kernel - Re: [PATCH] gitignore: Don't ignore 'tags' directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2548d95e-2441-4c23-8df7-1f601a0bd8a3@fujitsu.com>
Date: Mon, 25 Nov 2024 08:30:38 +0000
From: "Zhijian Li (Fujitsu)" <lizhijian@...itsu.com>
To: Masahiro Yamada <masahiroy@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Nathan
 Chancellor <nathan@...nel.org>, Kris Van Hees <kris.van.hees@...cle.com>,
	"rostedt@...dmis.org" <rostedt@...dmis.org>, kernel test robot
	<lkp@...el.com>
Subject: Re: [PATCH] gitignore: Don't ignore 'tags' directory



On 25/11/2024 16:21, Masahiro Yamada wrote:
> On Mon, Nov 25, 2024 at 4:23 PM Li Zhijian <lizhijian@...itsu.com> wrote:
>>
>> LKP reported warnings [1] regarding files being ignored:
>>     tools/testing/selftests/arm64/tags/.gitignore: warning: ignored by one of the .gitignore files
>>     tools/testing/selftests/arm64/tags/Makefile: warning: ignored by one of the .gitignore files
>>     tools/testing/selftests/arm64/tags/tags_test.c: warning: ignored by one of the .gitignore files
>>
>> These warnings were generated by ./scripts/misc-check. Although these files
>> are tracked by Git and the warnings are false positives, adjusting the
>> .gitignore entries will prevent these warnings and ensure a smoother script
>> execution.
> 
> You do not need to mention a special tool because you can see them
> when building the kernel with W=1.
> 
> You can say "Building the kernel with W=1 shows ..."
> 
> 
> 
>>
>> [1] https://lore.kernel.org/linux-kselftest/202411251308.Vjm5MzVC-lkp@intel.com/
>>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Signed-off-by: Li Zhijian <lizhijian@...itsu.com>
>> ---
>>   .gitignore | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/.gitignore b/.gitignore
>> index 56972adb5031..e63dbba823cd 100644
>> --- a/.gitignore
>> +++ b/.gitignore
>> @@ -130,6 +130,9 @@ series
>>   tags
>>   TAGS
> 
> Unfortunately, GIT does not support "only match to regular files",
> but you can make the intention clearer:
> 
> 
> # ctags files
> tags
> !tags/
> TAGS
> 
> 
> 
> You can add "!tags/" right below "tags".> Then, your comment is unnecessary.

Thanks for your quickly review, i will update it soon

Thanks
Zhijian

> 
>