linux-kernel - RE: [PATCH v6 08/10] PCI: imx6: Use dwc common suspend resume method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AS8PR04MB86761B96527A40BB0055AD598C2E2@AS8PR04MB8676.eurprd04.prod.outlook.com>
Date: Mon, 25 Nov 2024 08:44:29 +0000
From: Hongxing Zhu <hongxing.zhu@....com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
CC: "l.stach@...gutronix.de" <l.stach@...gutronix.de>, "bhelgaas@...gle.com"
	<bhelgaas@...gle.com>, "lpieralisi@...nel.org" <lpieralisi@...nel.org>,
	"kw@...ux.com" <kw@...ux.com>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "shawnguo@...nel.org" <shawnguo@...nel.org>, Frank Li
	<frank.li@....com>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
	"festevam@...il.com" <festevam@...il.com>, "imx@...ts.linux.dev"
	<imx@...ts.linux.dev>, "kernel@...gutronix.de" <kernel@...gutronix.de>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v6 08/10] PCI: imx6: Use dwc common suspend resume method

> -----Original Message-----
> From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> Sent: 2024年11月23日 0:47
> To: Hongxing Zhu <hongxing.zhu@....com>
> Cc: l.stach@...gutronix.de; bhelgaas@...gle.com; lpieralisi@...nel.org;
> kw@...ux.com; robh@...nel.org; krzk+dt@...nel.org; conor+dt@...nel.org;
> shawnguo@...nel.org; Frank Li <frank.li@....com>; s.hauer@...gutronix.de;
> festevam@...il.com; imx@...ts.linux.dev; kernel@...gutronix.de;
> linux-pci@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v6 08/10] PCI: imx6: Use dwc common suspend resume
> method
> 
> On Mon, Nov 18, 2024 at 03:00:44AM +0000, Hongxing Zhu wrote:
> 
> [...]
> 
> > > > -static void imx_pcie_pm_turnoff(struct imx_pcie *imx_pcie) -{
> > > > -	struct device *dev = imx_pcie->pci->dev;
> > > > -
> > > > -	/* Some variants have a turnoff reset in DT */
> > > > -	if (imx_pcie->turnoff_reset) {
> > > > -		reset_control_assert(imx_pcie->turnoff_reset);
> > > > -		reset_control_deassert(imx_pcie->turnoff_reset);
> > >
> > > Where these are handled in imx_pcie_pme_turn_off()? If you removed
> > > them intentionally for a reason, it should be mentioned in commit
> message.
> > >
> > How about add the following descriptions into commit message?
> > SRC interface is used to do the PME_TURN_OFF operations before. It's
> > not very
> 
> What is SRC?
SRC is System Reset Control.
> 
> >  suitable. Now DWC common driver can do the PME_TURN_OFF kick off.
> > Switch to  this common methods, and remove the useless turnoff_reset
> manipulate codes.
> >
> 
> Hmm, so 'turnoff_reset' is used to send PME_Turn_Off msg?
Yes, it is.
> 
> If so, then you need to say in such a way that the reader should understand
> 'turnoff_reset' was used to send PME_Turn_Off and since the DWC
> implementation is used, it is not needed now.
Okay. Thanks.

Best Regards
Richard Zhu
> 
> - Mani
> 
> --
> மணிவண்ணன் சதாசிவம்