linux-kernel - Re: [PATCH v2 2/2] dt-bindings: mfd: cros-ec: add properties for thermal cooling cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e3b8e581-957e-48ef-8769-13a5b0667490@kernel.org>
Date: Mon, 25 Nov 2024 09:45:12 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sung-Chi Li <lschyi@...omium.org>, Benson Leung <bleung@...omium.org>,
 Guenter Roeck <groeck@...omium.org>, Sebastian Reichel <sre@...nel.org>,
 Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: chrome-platform@...ts.linux.dev, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: mfd: cros-ec: add properties for
 thermal cooling cells

On 25/11/2024 09:31, Sung-Chi Li wrote:
> A charger chip is connect to the ChromeOS Embedded Controller (EC).
> When external power input into the system, current would go through the
> charger chip, generating heat in the system. The EC supports limiting
> the input current, thus reducing the generated heat. As a result, EC is
> a simulated passive cooling device.

EC is not part of the SoC, therefore this is not a cooling device. It is
not thermal sensor either, but this you pushed before I could object.

> 
> We cannot reuse the existing charge managing mechanism in the power
> framework due to:
> 
> - The power framework requires the charger to expose its thermal status,
>   which is not a supported functionality on EC.

Fix power framework then.

> - We need to use different thermal sensors to run thermal control,
>   rather than using thermal sensor on the charger.

Nothing stops you from using thermal sensors or thermal control. Still,
this is not part of SoC, this is not thermal zone and this is not a SoC
cooling device.

NAK

Best regards,
Krzysztof