linux-kernel - Re: [PATCH 1/5] dt-bindgins: display: Add Apple pre-DCP display controller bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <173250040970.6667.2839660338071681474.robh@kernel.org>
Date: Sun, 24 Nov 2024 20:06:51 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Sasha Finkelstein <fnkl.kernel@...il.com>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
 Maxime Ripard <mripard@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
 Thomas Zimmermann <tzimmermann@...e.de>, asahi@...ts.linux.dev, 
 David Airlie <airlied@...il.com>, devicetree@...r.kernel.org, 
 Alyssa Rosenzweig <alyssa@...enzweig.io>, 
 linux-arm-kernel@...ts.infradead.org, 
 Jessica Zhang <quic_jesszhan@...cinc.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Neil Armstrong <neil.armstrong@...aro.org>, 
 Hector Martin <marcan@...can.st>, linux-kernel@...r.kernel.org, 
 dri-devel@...ts.freedesktop.org, Simona Vetter <simona@...ll.ch>, 
 Sven Peter <sven@...npeter.dev>
Subject: Re: [PATCH 1/5] dt-bindgins: display: Add Apple pre-DCP display
 controller bindings


On Sun, 24 Nov 2024 23:29:24 +0100, Sasha Finkelstein wrote:
> Add bindings for a secondary display controller present on certain
> Apple laptops.
> 
> Signed-off-by: Sasha Finkelstein <fnkl.kernel@...il.com>
> ---
>  .../bindings/display/apple,display-pipe.yaml       | 59 ++++++++++++++++++++++
>  .../bindings/display/panel/apple,summit.yaml       | 24 +++++++++
>  2 files changed, 83 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/display/apple,display-pipe.yaml:21:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241124-adpdrm-v1-1-3191d8e6e49a@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.