linux-kernel - RE: [PATCH 1/2] dt-bindings: hwmon: (pmbus/adp1050): Add bindings for adp1051, adp1055 and ltp8800

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PH0PR03MB6938F9DE7173FE958D645CFE8E2E2@PH0PR03MB6938.namprd03.prod.outlook.com>
Date: Mon, 25 Nov 2024 02:44:39 +0000
From: "Encarnacion, Cedric justine" <Cedricjustine.Encarnacion@...log.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Guenter Roeck <linux@...ck-us.net>,
        Conor Dooley <conor@...nel.org>
CC: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        Jean Delvare
	<jdelvare@...e.com>, Jonathan Corbet <corbet@....net>,
        Delphine CC Chiu
	<Delphine_CC_Chiu@...ynn.com>,
        Rob Herring <robh@...nel.org>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        "Sabau,
 Radu bogdan" <Radu.Sabau@...log.com>,
        Uwe Kleine-König
	<u.kleine-koenig@...gutronix.de>,
        "Torreno, Alexis Czezar"
	<AlexisCzezar.Torreno@...log.com>,
        Andy Shevchenko
	<andriy.shevchenko@...ux.intel.com>
Subject: RE: [PATCH 1/2] dt-bindings: hwmon: (pmbus/adp1050): Add bindings for
 adp1051, adp1055 and ltp8800

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Thursday, November 21, 2024 2:39 AM
> To: Guenter Roeck <linux@...ck-us.net>; Conor Dooley <conor@...nel.org>;
> Encarnacion, Cedric justine <Cedricjustine.Encarnacion@...log.com>
> Cc: devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> i2c@...r.kernel.org; linux-doc@...r.kernel.org; linux-hwmon@...r.kernel.org;
> Jean Delvare <jdelvare@...e.com>; Jonathan Corbet <corbet@....net>;
> Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>; Rob Herring
> <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor Dooley
> <conor+dt@...nel.org>; Sabau, Radu bogdan <Radu.Sabau@...log.com>; Uwe
> Kleine-König <u.kleine-koenig@...gutronix.de>; Torreno, Alexis Czezar
> <AlexisCzezar.Torreno@...log.com>; Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com>
> Subject: Re: [PATCH 1/2] dt-bindings: hwmon: (pmbus/adp1050): Add bindings
> for adp1051, adp1055 and ltp8800
> 
> [External]
> 
> On 20/11/2024 19:07, Guenter Roeck wrote:
> > On 11/20/24 09:35, Krzysztof Kozlowski wrote:
> >> On 20/11/2024 18:11, Conor Dooley wrote:
> >>> On Wed, Nov 20, 2024 at 11:58:25AM +0800, Cedric Encarnacion wrote:
> >>>> add dt-bindings for adp1051, adp1055, and ltp8800 pmbus.
> >>>>      ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature
> >>>>      ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature
> >>>>      LTP8800-1A/-2/-4A: 150A/135A/200A DC/DC µModule Regulator
> >>>>
> >>>> Co-developed-by: Alexis Czezar Torreno
> <alexisczezar.torreno@...log.com>
> >>>> Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@...log.com>
> >>>> Signed-off-by: Cedric Encarnacion
> <cedricjustine.encarnacion@...log.com>
> >>>
> >>> Why did you drop my ack?
> >>> https://urldefense.com/v3/__https://lore.kernel.org/all/20241106-
> linoleum-kebab-
> decf14f54f76@...d/__;!!A3Ni8CS0y2Y!7Q2KluGdg8cJW_wYUd-
> vh5mP66Ns62VZOkPG4Jf7NY9ULtTfjiwYqrUHbik_tI9X4izI6fAQS_7eVscdEFK_X
> OEm$
> >> So that's a v2? Or v3? Then should be marked correctly. Please start
> >> using b4. I already asked analog.com for this in few cases. Feel free
> >> not to use b4 if you send correct patches, but this is not the case here.
> >>

Okay, I will start exploring b4 for future patches.

> >
> > In general I agree, but this is a combination of two patch series, as mentioned
> > in the summary. I am not sure how to use versioning in such situations. Is it
> > v2 of one series or v3 of the other ?
> I would say the highest and keep the b4 changeset. This allows to use b4
> diff easily. Choice done here - v1, no usage of b4  - breaks everything,
> look:
> 
> b4 diff '<20241120035826.3920-1-cedricjustine.encarnacion@...log.com>'
> Grabbing thread from
> lore.kernel.org/all/20241120035826.3920-1-
> cedricjustine.encarnacion@...log.com/t.mbox.gz
> ---
> Analyzing 13 messages in the thread
> Could not find lower series to compare against.

This is v2 of one and v3 of another. For the upcoming versions, should I
proceed to v4 which succeeds the highest or continue to v2 based on this
series?

Regards,
Cedric