linux-kernel - Re: [PATCH v1 1/1] ASoc: mediatek: mt8365: Don't use "proxy" headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z0RkaqfID9v0age_@smile.fi.intel.com>
Date: Mon, 25 Nov 2024 13:50:02 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Alexandre Mergnat <amergnat@...libre.com>
Cc: Mark Brown <broonie@...nel.org>, Nicolas Belin <nbelin@...libre.com>,
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v1 1/1] ASoc: mediatek: mt8365: Don't use "proxy" headers

On Mon, Nov 25, 2024 at 12:32:13PM +0100, Alexandre Mergnat wrote:
> Hello Andy.
> 
> Actually, after test it, "linux/of_gpio.h" isn't needed at all anymore.
> 
> That mean all added include in this patch aren't required.

Do you mean the driver doesn't not use types from types.h or dev_*() macros
from dev_printk.h? I don't believe this, sorry.

Basically what you are trying to say is "let's move of_gpio.h implicit
includes to become something else's problem". It's not what this patch
intended to do.

> On 04/11/2024 22:12, Mark Brown wrote:
> > On Mon, Nov 04, 2024 at 09:06:26PM +0200, Andy Shevchenko wrote:
> > > On Thu, Oct 31, 2024 at 12:27:25PM +0200, Andy Shevchenko wrote:
> > > > Update header inclusions to follow IWYU (Include What You Use)
> > > > principle.
> > 
> > > Hmm... I think we are waiting for somebody to Ack / review this change?
> > 
> > Yes.

-- 
With Best Regards,
Andy Shevchenko